Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2472563002: Fix for a DCHECK in GpuSurfaceLookup (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
Reviewers:
Oliver Chang, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. Committed: https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef Cr-Commit-Position: refs/heads/master@{#429350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 3 chunks +9 lines, -20 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Jay Civelli
4 years, 1 month ago (2016-11-01 22:03:38 UTC) #5
boliu
lgtm
4 years, 1 month ago (2016-11-01 22:09:31 UTC) #6
Jay Civelli
Adding @ochang for OWNER's review of gpu/ipc/common Thanks.
4 years, 1 month ago (2016-11-01 22:55:10 UTC) #8
Oliver Chang
lgtm
4 years, 1 month ago (2016-11-01 23:16:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472563002/1
4 years, 1 month ago (2016-11-01 23:18:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/172360)
4 years, 1 month ago (2016-11-02 01:02:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472563002/1
4 years, 1 month ago (2016-11-02 18:39:03 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 18:44:34 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:54:06 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef
Cr-Commit-Position: refs/heads/master@{#429350}

Powered by Google App Engine
This is Rietveld 408576698