|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Jay Civelli Modified:
4 years, 1 month ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGpuSurfaceTracker should not be a source set other components depend on.
As it is today, different components depending on it would end up with
multiple instances of the GpuSurfaceTracker singleton.
GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only
one instance (part of the gpu component), causing a DCHECK.
This CL moves the GpuSurfaceTracker to the gpu component like
GpuSurfaceLookup.
BUG=661333
TEST=content_shell should still work on Android and Mac.
Committed: https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef
Cr-Commit-Position: refs/heads/master@{#429350}
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== Make SurfaceTracker part of the ipc/common code. BUG= ========== to ========== Make SurfaceTracker part of the ipc/common code. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Make SurfaceTracker part of the ipc/common code. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it end up with multiple instances of the singleton which extends GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. BUG=661333 TEST=content_shell should still work on Android and Mac. ==========
Description was changed from ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it end up with multiple instances of the singleton which extends GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. BUG=661333 TEST=content_shell should still work on Android and Mac. ========== to ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. ==========
jcivelli@chromium.org changed reviewers: + boliu@chromium.org
lgtm
jcivelli@chromium.org changed reviewers: + ochang@chromium.org
Adding @ochang for OWNER's review of gpu/ipc/common Thanks.
lgtm
The CQ bit was checked by jcivelli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jcivelli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. ========== to ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. ========== to ========== GpuSurfaceTracker should not be a source set other components depend on. As it is today, different components depending on it would end up with multiple instances of the GpuSurfaceTracker singleton. GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only one instance (part of the gpu component), causing a DCHECK. This CL moves the GpuSurfaceTracker to the gpu component like GpuSurfaceLookup. BUG=661333 TEST=content_shell should still work on Android and Mac. Committed: https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef Cr-Commit-Position: refs/heads/master@{#429350} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef Cr-Commit-Position: refs/heads/master@{#429350} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
