third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp - Issue 2472543002: remove legacy Skia flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2472543002: remove legacy Skia flags (Closed)

Patch Set: address nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h ('k') | third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

index 00b0a2ddb4afe36e632fa67ab551fec7c33854b7..72000926bf2f48aeef54bd80c41870358ee995d4 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

@@ -224,7 +224,7 @@ bool OffscreenCanvasRenderingContext2D::stateHasFilter() {

return false;

}

-SkImageFilter* OffscreenCanvasRenderingContext2D::stateGetFilter() {

+sk_sp<SkImageFilter> OffscreenCanvasRenderingContext2D::stateGetFilter() {

// TODO: make getFilter accept nullptr

// return state().getFilter(nullptr, nullptr, IntSize(width(), height()),

// this);