third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h - Issue 2472543002: remove legacy Skia flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

Issue 2472543002: remove legacy Skia flags (Closed)

Patch Set: address nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

index e14cb77baabfa57cea8e4a8b502b9ec191eb3135..a821724b5cec7473f8947c82e08a24407e092e94 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

@@ -63,7 +63,7 @@ class MODULES_EXPORT PaintRenderingContext2D

// host to determine 'em' units etc in filters. At the moment just pretend

// that we don't have a filter set.

bool stateHasFilter() final { return false; }

- SkImageFilter* stateGetFilter() final { return nullptr; }

+ sk_sp<SkImageFilter> stateGetFilter() final { return nullptr; }

void snapshotStateForFilter() final {}

void validateStateStack() const final;