third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 2472543002: remove legacy Skia flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 2472543002: remove legacy Skia flags (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h ('K') | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index ed269d7ac3202520c7ac695c65d485bb76214a29..dc6968fe6d8bc2a92a90b83186409d4caf1e9749 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -543,7 +543,7 @@ const SkPaint* CanvasRenderingContext2DState::getPaint(

if (shadowMode == DrawShadowOnly) {

if (imageType == NonOpaqueImage || m_filterValue) {

paint->setLooper(0);

- paint->setImageFilter(shadowOnlyImageFilter());

+ paint->setImageFilter(sk_ref_sp(shadowOnlyImageFilter()));

return paint;

}

paint->setLooper(sk_ref_sp(shadowOnlyDrawLooper()));

@@ -554,7 +554,7 @@ const SkPaint* CanvasRenderingContext2DState::getPaint(

ASSERT(shadowMode == DrawShadowAndForeground);

if (imageType == NonOpaqueImage) {

paint->setLooper(0);

- paint->setImageFilter(shadowAndForegroundImageFilter());

+ paint->setImageFilter(sk_ref_sp(shadowAndForegroundImageFilter()));

return paint;

}

paint->setLooper(sk_ref_sp(shadowAndForegroundDrawLooper()));