third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h - Issue 2472543002: remove legacy Skia flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Issue 2472543002: remove legacy Skia flags (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

index 8da21d7eabf909071f1398eb4a5319750be01b0b..dccc76077919cd1be8c55658d8e39bac865b2666 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

@@ -455,7 +455,7 @@ void BaseRenderingContext2D::compositedDraw(

c->restoreToCount(saveCount);

}

- compositePaint.setImageFilter(filter);

+ compositePaint.setImageFilter(sk_ref_sp(filter));

Stephen White 2016/11/01 21:11:48 Rather than doing an explicit ref here, I think we

c->saveLayer(nullptr, &compositePaint);

SkPaint foregroundPaint =

*state().getPaint(paintType, DrawForegroundOnly, imageType);