Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2472533002:
Update expectations for filter effect pixel tests. (Closed)
|
Created:
4 years, 1 month ago by erikchen Modified:
4 years, 1 month ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate expectations for filter effect pixel tests.
Reference images look correct:
gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png
gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png
BUG=660600, 581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/18cdab375861899edb98261fec71f14360a1934a
Cr-Commit-Position: refs/heads/master@{#429355}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG= ========== to ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600, 581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + kbr@chromium.org
kbr: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm assuming the reference images have been verified.
On 2016/11/01 20:57:49, Ken Russell wrote: > lgtm assuming the reference images have been verified. yup
The CQ bit was checked by erikchen@chromium.org
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600, 581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600, 581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600, 581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update expectations for filter effect pixel tests. Reference images look correct: gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_NoOverlays_v3_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_CSSFilterEffects_v3_mac_8086_0a2e_msaa.png BUG=660600, 581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/18cdab375861899edb98261fec71f14360a1934a Cr-Commit-Position: refs/heads/master@{#429355} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/18cdab375861899edb98261fec71f14360a1934a Cr-Commit-Position: refs/heads/master@{#429355} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
