Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2472523002: Revert of [Devtools] Fix network timeline canvas selection splitview (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.NetworkLogView} networkLogView 7 * @param {!WebInspector.NetworkLogView} networkLogView
8 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator 8 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
9 * @param {!WebInspector.NetworkTransferDurationCalculator} durationCalculator 9 * @param {!WebInspector.NetworkTransferDurationCalculator} durationCalculator
10 * @param {!WebInspector.Setting} networkLogLargeRowsSetting 10 * @param {!WebInspector.Setting} networkLogLargeRowsSetting
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline")) 752 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline"))
753 return; 753 return;
754 // TODO(allada) Move this code into the code above. 754 // TODO(allada) Move this code into the code above.
755 if (gridMode) { 755 if (gridMode) {
756 this._splitWidget.showBoth(); 756 this._splitWidget.showBoth();
757 this._activeScroller = this._timelineScroller; 757 this._activeScroller = this._timelineScroller;
758 this._timelineScroller.scrollTop = this._dataGridScroller.scrollTop; 758 this._timelineScroller.scrollTop = this._dataGridScroller.scrollTop;
759 this._dataGridScroller.style.overflow = "hidden"; 759 this._dataGridScroller.style.overflow = "hidden";
760 this._dataGrid.setScrollContainer(this._timelineScroller); 760 this._dataGrid.setScrollContainer(this._timelineScroller);
761 } else { 761 } else {
762 this._splitWidget.hideSidebar(); 762 this._splitWidget.hideMain();
763 this._activeScroller = this._dataGridScroller; 763 this._activeScroller = this._dataGridScroller;
764 this._dataGridScroller.style.overflow = "overlay"; 764 this._dataGridScroller.style.overflow = "overlay";
765 this._dataGrid.setScrollContainer(this._dataGridScroller); 765 this._dataGrid.setScrollContainer(this._dataGridScroller);
766 } 766 }
767 }, 767 },
768 768
769 /** 769 /**
770 * @param {!WebInspector.NetworkLogViewColumns.Descriptor} columnConfig 770 * @param {!WebInspector.NetworkLogViewColumns.Descriptor} columnConfig
771 */ 771 */
772 _toggleColumnVisibility: function(columnConfig) 772 _toggleColumnVisibility: function(columnConfig)
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 { 1118 {
1119 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) { 1119 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) {
1120 this._shownEventDividers.delete(WebInspector.NetworkLogViewColumns._ filmStripDividerColor); 1120 this._shownEventDividers.delete(WebInspector.NetworkLogViewColumns._ filmStripDividerColor);
1121 this._redrawTimelineColumn(); 1121 this._redrawTimelineColumn();
1122 return; 1122 return;
1123 } 1123 }
1124 for (var divider of this._eventDividers) 1124 for (var divider of this._eventDividers)
1125 divider.element.classList.toggle("network-frame-divider-selected", f alse); 1125 divider.element.classList.toggle("network-frame-divider-selected", f alse);
1126 } 1126 }
1127 }; 1127 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698