Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2472523002: Revert of [Devtools] Fix network timeline canvas selection splitview (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
dgozman, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devtools] Fix network timeline canvas selection splitview (patchset #1 id:1 of https://codereview.chromium.org/2465373002/ ) Reason for revert: I'll reapply it. Original issue's description: > [Devtools] Fix network timeline canvas selection splitview > > This patch fixes a regression caused when a user selects a request > in the new network canvas timeline it would show the canvas to the left > instead of the name column. > > R=dgozman > BUG=653738 TBR=dgozman@chromium.org,allada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653738 Committed: https://crrev.com/658b8cbc437f96577e955a48097c7923b7f146aa Cr-Commit-Position: refs/heads/master@{#429097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pfeldman
Created Revert of [Devtools] Fix network timeline canvas selection splitview
4 years, 1 month ago (2016-11-01 20:31:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472523002/1
4 years, 1 month ago (2016-11-01 20:32:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 20:41:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/658b8cbc437f96577e955a48097c7923b7f146aa Cr-Commit-Position: refs/heads/master@{#429097}
4 years, 1 month ago (2016-11-01 20:45:38 UTC) #6
allada
4 years, 1 month ago (2016-11-01 21:33:46 UTC) #7
Message was sent while issue was closed.
I submitted the new patch already.

Powered by Google App Engine
This is Rietveld 408576698