Issue 24725002: Disposing an OSR job should only restore the back edge state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24725002: Disposing an OSR job should only restore the back edge state. (Closed)

Created:
7 years, 2 months ago by Yang

Modified:
7 years, 2 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disposing an OSR job should only restore the back edge state. R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16978

Patch Set 2 : addressed comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
	M	src/compiler.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/optimizing-compiler-thread.cc	View	1	8 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

LGTM with nits https://codereview.chromium.org/24725002/diff/1/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/24725002/diff/1/src/compiler.h#newcode536 src/compiler.h:536: bool IsCompilingForOSR() { return !info()->osr_ast_id().IsNone(); } ...

7 years, 2 months ago (2013-09-27 08:21:49 UTC) #2

Yang

7 years, 2 months ago (2013-09-27 09:37:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16978 (presubmit successful).

Expand Messages | Collapse Messages

Issue 24725002: Disposing an OSR job should only restore the back edge state. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages