Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2472483002: Sk4fLinearGradient fuzzer fixes (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4fLinearGradient fuzzer fixes 1) update in_range() to actually follow the documented rules regarding interval open/close endpoints 2) detect cases where the intervals provide negligible advance and fall back to using a color average BUG=skia:5647 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472483002 Committed: https://skia.googlesource.com/skia/+/afac581523af9de5e0af0af1dc128cac1b846006

Patch Set 1 #

Patch Set 2 : lower color average threshold #

Patch Set 3 : GM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -3 lines) Patch
M gm/gradients.cpp View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 3 chunks +42 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
f(malita)
4 years, 1 month ago (2016-11-01 19:42:49 UTC) #3
reed1
lgtm
4 years, 1 month ago (2016-11-01 20:08:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472483002/40001
4 years, 1 month ago (2016-11-01 20:22:15 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 20:41:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/afac581523af9de5e0af0af1dc128cac1b846006

Powered by Google App Engine
This is Rietveld 408576698