Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2472463002: [Mac] Use CoreWLAN directly now that macOS 10.9 is the minimum version. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Use CoreWLAN directly now that macOS 10.9 is the minimum version. BUG=606408 TEST=With WiFi turned on, go to https://maps.google.com, update current location, verify Net.WiFi histograms and AccessPointData. Committed: https://crrev.com/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf Cr-Commit-Position: refs/heads/master@{#430326}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -351 lines) Patch
M device/geolocation/BUILD.gn View 2 chunks +5 lines, -3 lines 0 comments Download
D device/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +0 lines, -192 lines 0 comments Download
M device/geolocation/wifi_data_provider_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
D device/geolocation/wifi_data_provider_mac.cc View 1 chunk +0 lines, -43 lines 0 comments Download
A + device/geolocation/wifi_data_provider_mac.mm View 4 chunks +52 lines, -109 lines 2 comments Download

Messages

Total messages: 20 (11 generated)
Robert Sesek
4 years, 1 month ago (2016-11-01 19:47:23 UTC) #6
Robert Sesek
Friendly ping.
4 years, 1 month ago (2016-11-04 14:06:49 UTC) #9
Robert Sesek
+mcasas
4 years, 1 month ago (2016-11-04 20:15:47 UTC) #11
mcasas
lgtm https://codereview.chromium.org/2472463002/diff/1/device/geolocation/wifi_data_provider_mac.mm File device/geolocation/wifi_data_provider_mac.mm (right): https://codereview.chromium.org/2472463002/diff/1/device/geolocation/wifi_data_provider_mac.mm#newcode109 device/geolocation/wifi_data_provider_mac.mm:109: const int kDefaultPollingInterval = 120000; // 2 mins ...
4 years, 1 month ago (2016-11-04 21:45:52 UTC) #12
Robert Sesek
https://codereview.chromium.org/2472463002/diff/1/device/geolocation/wifi_data_provider_mac.mm File device/geolocation/wifi_data_provider_mac.mm (right): https://codereview.chromium.org/2472463002/diff/1/device/geolocation/wifi_data_provider_mac.mm#newcode109 device/geolocation/wifi_data_provider_mac.mm:109: const int kDefaultPollingInterval = 120000; // 2 mins On ...
4 years, 1 month ago (2016-11-04 22:05:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472463002/1
4 years, 1 month ago (2016-11-07 17:27:16 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:51:03 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf Cr-Commit-Position: refs/heads/master@{#430326}
4 years, 1 month ago (2016-11-07 18:56:48 UTC) #19
Michael van Ouwerkerk
4 years, 1 month ago (2016-11-08 10:20:03 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698