Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: content/browser/compositor/vulkan_browser_compositor_output_surface.cc

Issue 2472433002: Fixed compile- and link-time errors with the "enable_vulkan" GN-argument (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/vulkan_browser_compositor_output_surface.cc
diff --git a/content/browser/compositor/vulkan_browser_compositor_output_surface.cc b/content/browser/compositor/vulkan_browser_compositor_output_surface.cc
index 31ef0b7808f61cf3e192adbe76f8e8d197b18621..0ed696e5e1904e978b247843a020f9a4dc0b9f53 100644
--- a/content/browser/compositor/vulkan_browser_compositor_output_surface.cc
+++ b/content/browser/compositor/vulkan_browser_compositor_output_surface.cc
@@ -11,8 +11,8 @@
namespace content {
VulkanBrowserCompositorOutputSurface::VulkanBrowserCompositorOutputSurface(
- const scoped_refptr<cc::VulkanContextProvider>& context,
- const scoped_refptr<ui::CompositorVSyncManager>& vsync_manager,
+ scoped_refptr<cc::VulkanContextProvider> context,
+ scoped_refptr<ui::CompositorVSyncManager> vsync_manager,
cc::SyntheticBeginFrameSource* begin_frame_source)
: BrowserCompositorOutputSurface(context,
danakj 2016/11/01 18:48:23 std::move
Sergey.Kipet 2016/11/04 22:15:36 Done.
vsync_manager,
danakj 2016/11/01 18:48:23 same
Sergey.Kipet 2016/11/04 22:15:36 Done.
@@ -43,16 +43,49 @@ void VulkanBrowserCompositorOutputSurface::Destroy() {
}
}
-void VulkanBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted(
- const std::vector<ui::LatencyInfo>& latency_info,
- gfx::SwapResult result,
- const gpu::GpuProcessHostedCALayerTreeParamsMac* params_mac) {
- RenderWidgetHostImpl::CompositorFrameDrawn(latency_info);
- client_->DidReceiveSwapBuffersAck();
+void VulkanBrowserCompositorOutputSurface::EnsureBackbuffer() {
+ NOTIMPLEMENTED();
+}
+
+void VulkanBrowserCompositorOutputSurface::DiscardBackbuffer() {
+ NOTIMPLEMENTED();
+}
+
+void VulkanBrowserCompositorOutputSurface::BindFramebuffer() {
+ NOTIMPLEMENTED();
+}
+
+bool VulkanBrowserCompositorOutputSurface::IsDisplayedAsOverlayPlane() const {
+ NOTIMPLEMENTED();
+ return false;
+}
+
+unsigned VulkanBrowserCompositorOutputSurface::GetOverlayTextureId() const {
+ NOTIMPLEMENTED();
+ return 0;
+}
+
+bool VulkanBrowserCompositorOutputSurface::SurfaceIsSuspendForRecycle() const {
+ NOTIMPLEMENTED();
+ return false;
+}
+
+void VulkanBrowserCompositorOutputSurface::Reshape(
+ const gfx::Size& size,
+ float device_scale_factor,
+ const gfx::ColorSpace& color_space,
+ bool has_alpha) {
+ NOTIMPLEMENTED();
+}
+
+uint32_t
+VulkanBrowserCompositorOutputSurface::GetFramebufferCopyTextureFormat() {
+ NOTIMPLEMENTED();
+ return 0;
}
void VulkanBrowserCompositorOutputSurface::SwapBuffers(
- cc::CompositorFrame* frame) {
+ cc::OutputSurfaceFrame frame) {
surface_->SwapBuffers();
danakj 2016/11/01 18:48:23 This needs to post-task back a call to client_->Di
Sergey.Kipet 2016/11/04 22:15:36 Done.
}

Powered by Google App Engine
This is Rietveld 408576698