Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: net/spdy/spdy_frame_builder_test.cc

Issue 247243003: SPDY: Use SpdyMajorVersion rather than ints for SPDY version number. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also include cr/64899106 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_frame_builder_test.cc
diff --git a/net/spdy/spdy_frame_builder_test.cc b/net/spdy/spdy_frame_builder_test.cc
index f966932fef8578c5ceac02076de6f58fd38234e0..66b97d5b2eff47475c106237861f2002bd74c0af 100644
--- a/net/spdy/spdy_frame_builder_test.cc
+++ b/net/spdy/spdy_frame_builder_test.cc
@@ -46,7 +46,7 @@ TEST_P(SpdyFrameBuilderTest, RewriteLength) {
SpdySettingsIR settings_ir;
scoped_ptr<SpdyFrame> expected(framer.SerializeSettings(settings_ir));
SpdyFrameBuilder builder(expected->size() + 1, spdy_version_);
- if (spdy_version_ < 4) {
+ if (spdy_version_ <= SPDY3) {
builder.WriteControlFrameHeader(framer, SETTINGS, 0);
builder.WriteUInt32(0); // Write the number of settings.
} else {
@@ -63,7 +63,7 @@ TEST_P(SpdyFrameBuilderTest, OverwriteFlags) {
// Create a HEADERS frame both via framer and manually via builder with
// different flags set, then make them match using OverwriteFlags().
SpdyFramer framer(spdy_version_);
- if (spdy_version_ < SPDY4) {
+ if (spdy_version_ <= SPDY3) {
return;
}
SpdyHeadersIR headers_ir(1);
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698