Issue 247243003: SPDY: Use SpdyMajorVersion rather than ints for SPDY version number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247243003: SPDY: Use SpdyMajorVersion rather than ints for SPDY version number. (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SPDY: Use SpdyMajorVersion rather than ints for SPDY version number. Version comparisons are canonicalized on using the lowest applicable version number. Also add new SPDY5 enum (just the literal; no implementation). This lands server change 64786464 by mlavan. Fix a bug in cl/64786464 that could cause SPDY version to be mis-parsed in the framer. This lands server change 64899106 by mlavan. BUG=345769

Patch Set 1 #

Patch Set 2 : Also include cr/64899106 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -84 lines)			Patch
M	net/spdy/spdy_frame_builder.cc	View		6 chunks	+9 lines, -9 lines	0 comments	Download
M	net/spdy/spdy_frame_builder_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_framer.h	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1	11 chunks	+28 lines, -19 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View		30 chunks	+32 lines, -31 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View		2 chunks	+10 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_protocol.cc	View	1	14 chunks	+61 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_protocol_test.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_test_utils.h	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_test_utils.cc	View		3 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages