Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2472413003: MD Settings: remove a bunch of unneeded profile.content_settings.* pref objects from prefs_util.cc (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dschuyler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove a bunch of unneeded profile.content_settings.* pref objects from prefs_util.cc R=stevenjb@chromium.org BUG=662492 Committed: https://crrev.com/7dbb891bea9eb2d5e735dd599e74d1006082e871 Cr-Commit-Position: refs/heads/master@{#430342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
4 years, 1 month ago (2016-11-05 00:04:09 UTC) #2
Dan Beam
/cc dschuyler@ so he doesn't double-do this
4 years, 1 month ago (2016-11-05 00:04:32 UTC) #5
stevenjb
lgtm
4 years, 1 month ago (2016-11-07 18:39:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472413003/1
4 years, 1 month ago (2016-11-07 18:40:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:25:32 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:35:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dbb891bea9eb2d5e735dd599e74d1006082e871
Cr-Commit-Position: refs/heads/master@{#430342}

Powered by Google App Engine
This is Rietveld 408576698