Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2472413002: [crankshaft] Fix constant folding of HDiv instruction. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix constant folding of HDiv instruction. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-662367 BUG=chromium:662367 Committed: https://crrev.com/9906b3e677ccfd43b79efca6892d38fe804f7ff8 Cr-Commit-Position: refs/heads/master@{#40773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-662367.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-04 13:34:37 UTC) #2
Michael Starzinger
4 years, 1 month ago (2016-11-04 13:35:11 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-04 14:54:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472413002/1
4 years, 1 month ago (2016-11-04 15:05:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 15:08:05 UTC) #10
Benedikt Meurer
Awesome, LGTM.
4 years, 1 month ago (2016-11-04 16:24:11 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9906b3e677ccfd43b79efca6892d38fe804f7ff8
Cr-Commit-Position: refs/heads/master@{#40773}

Powered by Google App Engine
This is Rietveld 408576698