Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2472403002: [Sensors] Align sensor reading attribute implementation with the specification (Closed)
Patch Set: Comments from Tim Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/Sensor.h
diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h
index e1aacf407cdb04730dc594e605b3498a1959e2bf..2020d7633eb5887760099a41113172e9033b391e 100644
--- a/third_party/WebKit/Source/modules/sensor/Sensor.h
+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h
@@ -66,7 +66,8 @@ class Sensor : public EventTargetWithInlineData,
const SensorOptions&,
ExceptionState&,
device::mojom::blink::SensorType);
- virtual SensorReading* createSensorReading(SensorProxy*) = 0;
+ virtual std::unique_ptr<SensorReadingFactory>
+ createSensorReadingFactory() = 0;
using SensorConfigurationPtr = device::mojom::blink::SensorConfigurationPtr;
using SensorConfiguration = device::mojom::blink::SensorConfiguration;
@@ -111,13 +112,12 @@ class Sensor : public EventTargetWithInlineData,
void notifyError(DOMException* error);
private:
- Member<SensorReading> m_sensorReading;
SensorOptions m_sensorOptions;
device::mojom::blink::SensorType m_type;
SensorState m_state;
Member<SensorProxy> m_sensorProxy;
std::unique_ptr<SensorPollingStrategy> m_polling;
- SensorProxy::Reading m_storedData;
+ device::SensorReading m_storedData;
SensorConfigurationPtr m_configuration;
};
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/BUILD.gn ('k') | third_party/WebKit/Source/modules/sensor/Sensor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698