Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/SensorReading.cpp

Issue 2472403002: [Sensors] Align sensor reading attribute implementation with the specification (Closed)
Patch Set: Comments from Tim Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/sensor/SensorReading.h" 5 #include "modules/sensor/SensorReading.h"
6 6
7 #include "core/dom/ExecutionContext.h" 7 #include "core/dom/ExecutionContext.h"
8 #include "core/frame/LocalDOMWindow.h" 8 #include "core/frame/LocalDOMWindow.h"
9 #include "core/timing/DOMWindowPerformance.h" 9 #include "core/timing/DOMWindowPerformance.h"
10 #include "core/timing/Performance.h" 10 #include "core/timing/Performance.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 SensorReading::SensorReading(SensorProxy* sensorProxy) 14 SensorReading::SensorReading(const device::SensorReading& data)
15 : m_sensorProxy(sensorProxy) {} 15 : m_data(data) {}
16 16
17 SensorReading::~SensorReading() = default; 17 SensorReading::~SensorReading() = default;
18 18
19 DEFINE_TRACE(SensorReading) {
20 visitor->trace(m_sensorProxy);
21 }
22
23 DOMHighResTimeStamp SensorReading::timeStamp(ScriptState* scriptState) const { 19 DOMHighResTimeStamp SensorReading::timeStamp(ScriptState* scriptState) const {
24 LocalDOMWindow* window = scriptState->domWindow(); 20 LocalDOMWindow* window = scriptState->domWindow();
25 if (!window) 21 if (!window)
26 return 0.0; 22 return 0.0;
27 23
28 Performance* performance = DOMWindowPerformance::performance(*window); 24 Performance* performance = DOMWindowPerformance::performance(*window);
29 DCHECK(performance); 25 DCHECK(performance);
30 26
31 if (!m_sensorProxy) { 27 return performance->monotonicTimeToDOMHighResTimeStamp(data().timestamp);
32 // In cases when SensorReading derived classes are constructed from JS
33 // side, e.g. to create syntetic SensorReadingEvent for testing
34 // purposes, |m_sensorProxy| will be null and SensorReading.timeStamp
35 // would return current DOMHighResTimeStamp, while reading value should
36 // be provided by derived classes.
37 return performance->now();
38 }
39
40 return performance->monotonicTimeToDOMHighResTimeStamp(
41 m_sensorProxy->reading().timestamp);
42 } 28 }
43 29
44 } // namespace blink 30 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698