Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2472343002: Race OnStartLoadingResponseBody and OnReceiveResponse of NavigationPreloadRequest. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 1973 matching lines...) Expand 10 before | Expand all | Expand 10 after
1984 const GURL redirect_page_url = 1984 const GURL redirect_page_url =
1985 embedded_test_server()->GetURL(kRedirectPageUrl).Resolve("?1"); 1985 embedded_test_server()->GetURL(kRedirectPageUrl).Resolve("?1");
1986 const GURL in_scope_redirect_page_url = 1986 const GURL in_scope_redirect_page_url =
1987 embedded_test_server()->GetURL(kInScopeRedirectPageUrl).Resolve("?2"); 1987 embedded_test_server()->GetURL(kInScopeRedirectPageUrl).Resolve("?2");
1988 const GURL cross_origin_redirect_page_url = 1988 const GURL cross_origin_redirect_page_url =
1989 embedded_test_server()->GetURL("a.com", kRedirectPageUrl).Resolve("?3"); 1989 embedded_test_server()->GetURL("a.com", kRedirectPageUrl).Resolve("?3");
1990 1990
1991 // Navigate to a same-origin, out of scope URL that redirects to the target 1991 // Navigate to a same-origin, out of scope URL that redirects to the target
1992 // URL. The navigation preload request should be the single request to the 1992 // URL. The navigation preload request should be the single request to the
1993 // target URL. 1993 // target URL.
1994 TitleWatcher title_watcher1(shell()->web_contents(), 1994 const base::string16 title1 = base::ASCIIToUTF16("?1");
1995 base::ASCIIToUTF16("?1")); 1995 TitleWatcher title_watcher1(shell()->web_contents(), title1);
1996 NavigateToURL(shell(), redirect_page_url); 1996 NavigateToURL(shell(), redirect_page_url);
1997 EXPECT_EQ(title1, title_watcher1.WaitAndGetTitle());
1997 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?1")); 1998 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?1"));
1998 1999
1999 // Navigate to a same-origin, in-scope URL that redirects to the target URL. 2000 // Navigate to a same-origin, in-scope URL that redirects to the target URL.
2000 // The navigation preload request should be the single request to the target 2001 // The navigation preload request should be the single request to the target
2001 // URL. 2002 // URL.
2002 TitleWatcher title_watcher2(shell()->web_contents(), 2003 const base::string16 title2 = base::ASCIIToUTF16("?2");
2003 base::ASCIIToUTF16("?2")); 2004 TitleWatcher title_watcher2(shell()->web_contents(), title2);
2004 NavigateToURL(shell(), in_scope_redirect_page_url); 2005 NavigateToURL(shell(), in_scope_redirect_page_url);
2006 EXPECT_EQ(title2, title_watcher2.WaitAndGetTitle());
2005 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?2")); 2007 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?2"));
2006 2008
2007 // Navigate to a cross-origin URL that redirects to the target URL. The 2009 // Navigate to a cross-origin URL that redirects to the target URL. The
2008 // navigation preload request should be the single request to the target URL. 2010 // navigation preload request should be the single request to the target URL.
2009 TitleWatcher title_watcher3(shell()->web_contents(), 2011 const base::string16 title3 = base::ASCIIToUTF16("?3");
2010 base::ASCIIToUTF16("?3")); 2012 TitleWatcher title_watcher3(shell()->web_contents(), title3);
2011 NavigateToURL(shell(), cross_origin_redirect_page_url); 2013 NavigateToURL(shell(), cross_origin_redirect_page_url);
2014 EXPECT_EQ(title3, title_watcher3.WaitAndGetTitle());
2012 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?3")); 2015 EXPECT_EQ(1, GetRequestCount(kPageUrl + "?3"));
2013 } 2016 }
2014 2017
2018 // When the content type of the page is not correctly set,
2019 // OnStartLoadingResponseBody() of mojom::URLLoaderClient is called before
2020 // OnReceiveResponse(). This behavior is caused by MimeSniffingResourceHandler.
2021 // This test checks that even if the MimeSniffingResourceHandler is triggered
2022 // navigation preload must be handled correctly.
2023 IN_PROC_BROWSER_TEST_P(ServiceWorkerNavigationPreloadTest,
2024 RespondWithNavigationPreloadWithMimeSniffing) {
2025 const char kPageUrl[] = "/service_worker/navigation_preload.html";
2026 const char kWorkerUrl[] = "/service_worker/navigation_preload.js";
2027 const char kPage[] = "<title>PASS</title>Hello world.";
2028 const char kScript[] =
2029 "self.addEventListener('fetch', event => {\n"
2030 " event.respondWith(event.preloadResponse);\n"
2031 " });";
2032 const GURL page_url = embedded_test_server()->GetURL(kPageUrl);
2033 const GURL worker_url = embedded_test_server()->GetURL(kWorkerUrl);
2034
2035 // Setting an empty content type to trigger MimeSniffingResourceHandler.
2036 RegisterStaticFile(kPageUrl, kPage, "");
2037 RegisterStaticFile(kWorkerUrl, kScript, "text/javascript");
2038
2039 SetupForNavigationPreloadTest(page_url, worker_url,
2040 true /* enable_navigation_preload */);
2041
2042 const base::string16 title = base::ASCIIToUTF16("PASS");
2043 TitleWatcher title_watcher(shell()->web_contents(), title);
2044 NavigateToURL(shell(), page_url);
2045 EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
2046 EXPECT_EQ("Hello world.", GetTextContent());
2047
2048 // The page request must be sent only once, since the worker responded with
2049 // the navigation preload response
2050 EXPECT_EQ(1, GetRequestCount(kPageUrl));
2051 }
2052
2015 // Flaky on Win/Mac: http://crbug.com/533631 2053 // Flaky on Win/Mac: http://crbug.com/533631
2016 #if defined(OS_WIN) || defined(OS_MACOSX) 2054 #if defined(OS_WIN) || defined(OS_MACOSX)
2017 #define MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure DISABLED_ResponseFr omHTTPSServiceWorkerIsMarkedAsSecure 2055 #define MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure DISABLED_ResponseFr omHTTPSServiceWorkerIsMarkedAsSecure
2018 #else 2056 #else
2019 #define MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure ResponseFromHTTPSSe rviceWorkerIsMarkedAsSecure 2057 #define MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure ResponseFromHTTPSSe rviceWorkerIsMarkedAsSecure
2020 #endif 2058 #endif
2021 IN_PROC_BROWSER_TEST_P(ServiceWorkerBrowserTest, 2059 IN_PROC_BROWSER_TEST_P(ServiceWorkerBrowserTest,
2022 MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure) { 2060 MAYBE_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure) {
2023 const char kPageUrl[] = "/service_worker/fetch_event_blob.html"; 2061 const char kPageUrl[] = "/service_worker/fetch_event_blob.html";
2024 const char kWorkerUrl[] = "/service_worker/fetch_event_blob.js"; 2062 const char kWorkerUrl[] = "/service_worker/fetch_event_blob.js";
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
2723 ServiceWorkerV8CacheStrategiesNormalTest, 2761 ServiceWorkerV8CacheStrategiesNormalTest,
2724 ::testing::Values(true, false)); 2762 ::testing::Values(true, false));
2725 INSTANTIATE_TEST_CASE_P(ServiceWorkerBrowserTest, 2763 INSTANTIATE_TEST_CASE_P(ServiceWorkerBrowserTest,
2726 ServiceWorkerV8CacheStrategiesAggressiveTest, 2764 ServiceWorkerV8CacheStrategiesAggressiveTest,
2727 ::testing::Values(true, false)); 2765 ::testing::Values(true, false));
2728 INSTANTIATE_TEST_CASE_P(ServiceWorkerBrowserTest, 2766 INSTANTIATE_TEST_CASE_P(ServiceWorkerBrowserTest,
2729 ServiceWorkerDisableWebSecurityTest, 2767 ServiceWorkerDisableWebSecurityTest,
2730 ::testing::Values(true, false)); 2768 ::testing::Values(true, false));
2731 2769
2732 } // namespace content 2770 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698