Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2472323002: Revert of Delegate dragend to the correct frame's EventHandler. (Closed)

Created:
4 years, 1 month ago by tapted
Modified:
4 years, 1 month ago
Reviewers:
dcheng, pwnall
CC:
chromium-reviews, blink-reviews, dcheng, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delegate dragend to the correct frame's EventHandler. (patchset #4 id:120001 of https://codereview.chromium.org/2469863003/ ) Reason for revert: Suspected for drag-over-iframe-invalid-source-crash.html failure on WebKit Linux Precise Leak Starts https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1428 Error like ({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,23],"numberOfLiveResources":[0,1]}) Original issue's description: > Delegate dragend to the correct frame's EventHandler. > > Currently, most drag-and-drop events are correctly delegated to the > EventHandler of the frame that contains the events' target elements, in > EventHandler::updateDragAndDrop. However, > EventHandler::dragSourceEndedAt does not implement this delegation. The > issue is visible to the Web in a subtle way -- the frame of the > EventHandler is used to populate the DragEvent's view, which is used to > compute the clientX and clientY attributes, which are user-visible. > > This CL implements the delegation used by > MouseEventManager::dispatchDragSrcEvent, into > MouseEventManager::dispatchDragSrcEvent. > > BUG=618770 > > Committed: https://crrev.com/32e50971f32bcd21be8540758efe9aac0ffafcd9 > Cr-Commit-Position: refs/heads/master@{#429669} TBR=dcheng@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618770 Committed: https://crrev.com/4377f6270a5f3a53d2bb56f5a276c243aa36f7e8 Cr-Commit-Position: refs/heads/master@{#429789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -218 lines) Patch
D third_party/WebKit/LayoutTests/fast/dnd/event-mouse-coordinates.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dnd/event-mouse-coordinates-iframe.html View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dnd/resources/event-mouse-coordinates.css View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dnd/resources/event-mouse-coordinates.js View 1 chunk +0 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tapted
Created Revert of Delegate dragend to the correct frame's EventHandler.
4 years, 1 month ago (2016-11-04 05:12:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472323002/1
4 years, 1 month ago (2016-11-04 05:13:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 05:14:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472323002/1
4 years, 1 month ago (2016-11-04 05:14:21 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4377f6270a5f3a53d2bb56f5a276c243aa36f7e8 Cr-Commit-Position: refs/heads/master@{#429789}
4 years, 1 month ago (2016-11-04 05:16:02 UTC) #11
tapted
4 years, 1 month ago (2016-11-04 06:07:07 UTC) #12
Message was sent while issue was closed.
See http://crbug.com/662292 for the failures - forgot to link it sorry.

Powered by Google App Engine
This is Rietveld 408576698