Chromium Code Reviews
DescriptionRevert of Delegate dragend to the correct frame's EventHandler. (patchset #4 id:120001 of https://codereview.chromium.org/2469863003/ )
Reason for revert:
Suspected for drag-over-iframe-invalid-source-crash.html failure on WebKit Linux Precise Leak
Starts
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1428
Error like
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,23],"numberOfLiveResources":[0,1]})
Original issue's description:
> Delegate dragend to the correct frame's EventHandler.
>
> Currently, most drag-and-drop events are correctly delegated to the
> EventHandler of the frame that contains the events' target elements, in
> EventHandler::updateDragAndDrop. However,
> EventHandler::dragSourceEndedAt does not implement this delegation. The
> issue is visible to the Web in a subtle way -- the frame of the
> EventHandler is used to populate the DragEvent's view, which is used to
> compute the clientX and clientY attributes, which are user-visible.
>
> This CL implements the delegation used by
> MouseEventManager::dispatchDragSrcEvent, into
> MouseEventManager::dispatchDragSrcEvent.
>
> BUG=618770
>
> Committed: https://crrev.com/32e50971f32bcd21be8540758efe9aac0ffafcd9
> Cr-Commit-Position: refs/heads/master@{#429669}
TBR=dcheng@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618770
Committed: https://crrev.com/4377f6270a5f3a53d2bb56f5a276c243aa36f7e8
Cr-Commit-Position: refs/heads/master@{#429789}
Patch Set 1 #
Messages
Total messages: 12 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||