Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2472313002: DevTools: [Elements] fix text color of selected HTMLComment nodes (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
einbinder, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Elements] fix text color of selected HTMLComment nodes This patch turns text color to white for selected HTMLComment nodes. BUG=662226 R=dgozman, einbinder Committed: https://crrev.com/edcbe5232d2874dbc727c35fd54824e5bd9642fa Cr-Commit-Position: refs/heads/master@{#430148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-04 03:20:03 UTC) #1
einbinder
lgtm
4 years, 1 month ago (2016-11-04 19:34:44 UTC) #2
dgozman
Is this recent regression to merge? lgtm
4 years, 1 month ago (2016-11-04 19:36:46 UTC) #3
lushnikov
yes, I think we should merge this
4 years, 1 month ago (2016-11-04 19:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472313002/1
4 years, 1 month ago (2016-11-04 19:39:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/326178)
4 years, 1 month ago (2016-11-05 00:51:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472313002/1
4 years, 1 month ago (2016-11-05 03:06:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 04:19:58 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 04:22:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edcbe5232d2874dbc727c35fd54824e5bd9642fa
Cr-Commit-Position: refs/heads/master@{#430148}

Powered by Google App Engine
This is Rietveld 408576698