Add/improve ChromeVox feedback for switches

Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc
Cr-Commit-Position: refs/heads/master@{#429924}

[Evan Stade, 2016-11-04 02:44:27]

Description was changed from

==========
Update ChromeVox feedback for toggle buttons.

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". This more
closely matches Android (although there it's "on switch" and "off
switch" --- I went with the ordering precedent set by "radio selected".

BUG=652677
==========

to

==========
Update ChromeVox feedback for toggle buttons.

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". This more
closely matches Android (although there it's "on switch" and "off
switch" --- I went with the ordering precedent set by "radio selected".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Evan Stade, 2016-11-04 02:45:23]

estade@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Evan Stade, 2016-11-04 02:45:24]

+Dominic, wdyt? This seems more descriptive and closer to what Android does.
Without this change, we get something like "Enable Wi-Fi, button pressed"

[Evan Stade, 2016-11-04 02:48:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-11-04 02:48:14]

Description was changed from

==========
Update ChromeVox feedback for toggle buttons.

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". This more
closely matches Android (although there it's "on switch" and "off
switch" --- I went with the ordering precedent set by "radio selected".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update ChromeVox feedback for toggle buttons.

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". This more
closely matches Android (although there it's "on switch" and "off
switch" --- I went with the ordering precedent set by "radio selected".)

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-04 02:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:51:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-11-04 07:32:17]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2016-11-04 07:32:17]

+dtseng

I'm definitely in favor of improving the feedback,
but I'm hesitant to use the word "switch" because
there's actually an ARIA role "switch" now (which inherits
from "checkbox").

If what you have is a switch, consider using role="switch"
instead. You can use role="switch checkbox" in order to
fall back gracefully with screen readers that don't support
switch yet.

As for a toggle button, how about:

"pressed toggle button" / "unpressed toggle button"

or

"pressed button" / "unpressed button"

[Evan Stade, 2016-11-04 15:24:41]

On 2016/11/04 07:32:17, dmazzoni wrote:
> +dtseng
> 
> I'm definitely in favor of improving the feedback,
> but I'm hesitant to use the word "switch" because
> there's actually an ARIA role "switch" now (which inherits
> from "checkbox").
> 
> If what you have is a switch, consider using role="switch"
> instead. You can use role="switch checkbox" in order to
> fall back gracefully with screen readers that don't support
> switch yet.
> 
> As for a toggle button, how about:
> 
> "pressed toggle button" / "unpressed toggle button"
> 
> or
> 
> "pressed button" / "unpressed button"

What is the conceptual difference between a "toggle button" and a "switch" (or a
checkbox for that matter)?

Here is the context re: why I care about this:
https://codereview.chromium.org/2477983003/ (I see I'll need to change it a bit
because of your recent AXNode change). I'm happy to use AX_ROLE_SWITCH if that's
appropriate. Let me see what the output comes out to for that...

[Evan Stade, 2016-11-04 15:42:04]

Description was changed from

==========
Update ChromeVox feedback for toggle buttons.

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". This more
closely matches Android (although there it's "on switch" and "off
switch" --- I went with the ordering precedent set by "radio selected".)

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Evan Stade, 2016-11-04 15:43:29]

Alright, instead of changing toggle button, I'm making the same change
(addition) to switch. I still don't know what the difference between these
things is but this makes the output match the aria role name which seems like a
good thing.

[dmazzoni, 2016-11-04 16:17:16]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-11-04 16:17:17]

lgtm

We could probably still improve toggle buttons
somewhat, but this change lg.

[commit-bot: I haz the power, 2016-11-04 16:17:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:13:40]

Description was changed from

==========
Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-04 17:13:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 17:16:17]

Description was changed from

==========
Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add/improve ChromeVox feedback for switches

e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off".

BUG=652677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc
Cr-Commit-Position: refs/heads/master@{#429924}
==========

[commit-bot: I haz the power, 2016-11-04 17:16:18]

Patchset 2 (id:??) landed as
https://crrev.com/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc
Cr-Commit-Position: refs/heads/master@{#429924}