Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: content/renderer/media/webmediaplayer_ms_compositor.h

Issue 2472273002: Move passing of WebRTC rendering frames from main thread to compositor thread (Closed)
Patch Set: Make |render_frame_suspended_| android specific. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_ms_compositor.h
diff --git a/content/renderer/media/webmediaplayer_ms_compositor.h b/content/renderer/media/webmediaplayer_ms_compositor.h
index 9cdf20d7713be5f8ebcde62796ae05b87de9506b..710e1315951ccbfb0464b6eee8d9a6a37640cd2c 100644
--- a/content/renderer/media/webmediaplayer_ms_compositor.h
+++ b/content/renderer/media/webmediaplayer_ms_compositor.h
@@ -88,6 +88,8 @@ class CONTENT_EXPORT WebMediaPlayerMSCompositor
void StopRendering();
void ReplaceCurrentFrameWithACopy();
+ base::WeakPtr<WebMediaPlayerMSCompositor> GetWeakPtr();
perkj_chrome 2016/11/09 15:27:13 So these weakptr's may only be dereferences on the
emircan 2016/11/11 22:27:19 Yes, they would be used to post tasks on composito
+
private:
friend class WebMediaPlayerMSTest;
@@ -156,7 +158,7 @@ class CONTENT_EXPORT WebMediaPlayerMSCompositor
base::Lock current_frame_lock_;
// Make sure the weak pointer factory member is the last member of the class.
- base::WeakPtrFactory<WebMediaPlayerMSCompositor> weak_ptr_factory_;
+ base::WeakPtrFactory<WebMediaPlayerMSCompositor> weak_factory_for_compositor_;
DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerMSCompositor);
};

Powered by Google App Engine
This is Rietveld 408576698