chrome/utility/importer/firefox_importer.h - Issue 247223003: Parsed search.json for importing search engine settings from FireFox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/firefox_importer.h

Issue 247223003: Parsed search.json for importing search engine settings from FireFox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test coverage and addressed feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/firefox_importer_browsertest.cc ('K') | « chrome/test/data/firefox_profile/signons.sqlite ('k') | chrome/utility/importer/firefox_importer.cc » ('j') | chrome/utility/importer/firefox_importer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/firefox_importer.h

diff --git a/chrome/utility/importer/firefox_importer.h b/chrome/utility/importer/firefox_importer.h

index 64c3751bb14a19d7d8c4fd33b45afa0b65b9d0c8..0ad10d6093a3168bb7e3df05463ca7da4a6e48ce 100644

--- a/chrome/utility/importer/firefox_importer.h

+++ b/chrome/utility/importer/firefox_importer.h

@@ -47,6 +47,8 @@ class FirefoxImporter : public Importer {

// defined in browserconfig.properties.

void ImportHomepage();

void GetSearchEnginesXMLData(std::vector<std::string>* search_engine_data);

+ void GetSearchEnginesXMLDataFromJSON(

+ std::vector<std::string>* search_engine_data);

// The struct stores the information about a bookmark item.

struct BookmarkItem;