chrome/test/data/firefox_profile/README - Issue 247223003: Parsed search.json for importing search engine settings from FireFox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/firefox_profile/README

Issue 247223003: Parsed search.json for importing search engine settings from FireFox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed |import_search_engines_| flag such that search engines import test is always conducted. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/importer/firefox_importer_browsertest.cc ('K') | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/test/data/firefox_profile/cert8.db » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This directory is created to hold test data for Firefox importer browser tests.

	2

	3 Since Firefox 3.5, instead of search.sqlite, all search engines are stored in

	4 search.json. The test data in this directory is intended for Firefox 3.5 and

	5 later.

	6

	7 The search.json is grabbed from profile directory of Firefox 28.0 that runs in

	8 Ubuntu 12.04.4 LTS. To make this test search.json light weight, the keys

	9 \|_iconURL\| and \|_iconMapObj\| are removed from each search engines' dictionary.

	10 Moreover, each list of \|engines\| is updated to respect existing

	11 \|kFirefoxKeywords\|. Please NOTE that values of \|filePath\| is dependant on

	12 workstation. The values of \|filePath\| are location of XML files for Firefox

	13 search engines. All test XML files can be found in

	14 /src/chrome/test/data/firefox_searchplugins directory. The directory contains

	15 two sub-directories, namely \|default\| and \|custom\|. XML files for "default" and

	16 "custom/installed" search engines are placed in \|default\| and \|custom\|

	17 sub-directory respectively.

	18

	19 All other files are grabbed from

	20 /src/chrome/test/data/firefox35_profile because

	21

	22 1) They respect the existing \|kFirefoxBookmarks\|, \|kFirefoxPasswords\|

	23 of firefox_importer_browsertests.cc.

	24 2) Unlike search.sqlite, their behavior have not changed.

OLD	NEW