chrome/test/data/firefox3_profile/README - Issue 247223003: Parsed search.json for importing search engine settings from FireFox.

Side by Side Diff: chrome/test/data/firefox3_profile/README

Issue 247223003: Parsed search.json for importing search engine settings from FireFox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed text alignments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/importer/firefox_importer_browsertest.cc ('K') | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/test/data/firefox3_profile/search.sqlite » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 The search.sqlite contains a table named \|engine_data\| which holds information

	2 about search engines. The table's data has been modified for the sake of

	3 testing. The original content of \|engine_data\| looked as follows:

	4

	5 id engineid name value

	6 -- ------------------------- ----- -----

	7 10 [app]/google.xml order 1

	8 11 [app]/yahoo.xml order 2

	9 12 [app]/amazondotcom.xml order 3

	10 13 [app]/answers.xml order 4

	11 14 [app]/creativecommons.xml order 5

	12 15 [app]/eBay.xml order 6

	13 16 [profile]/flickr-tags.xml order 7

	14 17 [profile]/imdb.xml order 8

	15 18 [profile]/webster.xml order 9

	16 19 [app]/wikipedia.xml order 10

	17

	18 The \|engineid\| contains [app]/<name>.xml or [profile]/<name>.xml where

	19 the [app] and [profile] need to be replaced with the actual app or profile

	20 path. The actual app or profile path varies with operating system. To make
	Ilya Sherman 2014/06/06 04:15:42 Do the app and profile paths vary by operating sys Do the app and profile paths vary by operating system, even in the test setup? Looking more closely at the test code, it looks like SetUp() creates a temporary directory, and profile and app directories within it. Do these app and profile paths not get used? Tapu Ghose 2014/06/15 04:19:49 You are right. [app] and [profle] should not vary Show quoted text On 2014/06/06 04:15:42, Ilya Sherman wrote: > Do the app and profile paths vary by operating system, even in the test setup? > Looking more closely at the test code, it looks like SetUp() creates a temporary > directory, and profile and app directories within it. Do these app and profile > paths not get used? You are right. [app] and [profle] should not vary by operating system in test setup. Update test code to make use of app and profile paths.
	21 the browser test independant of machine's environment, [app] and [profile]

	22 is replaced with relative path as follows:

	23

	24 [app] => ./chrome/test/data/firefox3_profile/searchplugins/default

	25 [profile] => ./chrome/test/data/firefox3_profile/searchplugins/installed
	Ilya Sherman 2014/06/06 04:15:42 What is this path relative to? Since the test cod What is this path relative to? Since the test code copies all of the files over to a temporary directory, it seems unnecessary to have the "chrome/test/data/firefox3_profile" prefix. Ilya Sherman 2014/06/06 04:15:42 Also, I've realized that the test code expects the Also, I've realized that the test code expects the search engine XML files to all live in a common location. Rather than adding them once to //chrome/test/data/firefox3_profile/searchplugins and again to //chrome/test/data/firefox_profile/searchplugins, you could add them to //chrome/test/data/firefox_searchplugins. You'd then have the test code copy over the contents of this directory to {tempdir}/app/searchplugins. Does that make sense? Tapu Ghose 2014/06/15 04:19:49 Completely agree with you. All search engine XML f Show quoted text On 2014/06/06 04:15:42, Ilya Sherman wrote: > Also, I've realized that the test code expects the search engine XML files to > all live in a common location. Rather than adding them once to > //chrome/test/data/firefox3_profile/searchplugins and again to > //chrome/test/data/firefox_profile/searchplugins, you could add them to > //chrome/test/data/firefox_searchplugins. You'd then have the test code copy > over the contents of this directory to {tempdir}/app/searchplugins. Does that > make sense? Completely agree with you. All search engine XML files are placed in //chrome/test/data/firefox_searchplugins and updated test code accordingly. Tapu Ghose 2014/06/15 04:19:49 The path was relative to /src. But now I made use Show quoted text On 2014/06/06 04:15:42, Ilya Sherman wrote: > What is this path relative to? Since the test code copies all of the files over > to a temporary directory, it seems unnecessary to have the > "chrome/test/data/firefox3_profile" prefix. The path was relative to /src. But now I made use of temporary directory.
	26

	27 To respect the relative path in test data, all default and installed search

	28 engines XMLs are placed in searchplugins/default and searchplugins/installed

	29 directory respectively.

OLD	NEW