Issue 2472223002: WIP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2472223002: WIP (Closed)

Created:
4 years, 1 month ago by hidehiko

Modified:
4 years, 1 month ago

Reviewers:
Luis Héctor Chávez

CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, alemate+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WIP BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+465 lines, -266 lines)			Patch
M	chrome/browser/chromeos/arc/arc_auth_service.h	View	8 chunks	+21 lines, -24 lines	0 comments	Download
M	chrome/browser/chromeos/arc/arc_auth_service.cc	View	22 chunks	+105 lines, -92 lines	0 comments	Download
M	chrome/browser/chromeos/arc/arc_support_host.h	View	5 chunks	+104 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/arc/arc_support_host.cc	View	12 chunks	+189 lines, -76 lines	0 comments	Download
M	chrome/browser/resources/chromeos/arc_support/background.js	View	9 chunks	+46 lines, -59 lines	1 comment	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Luis Héctor Chávez

4 years, 1 month ago (2016-11-04 17:08:55 UTC) #3

https://codereview.chromium.org/2472223002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/arc_support/background.js (left):

https://codereview.chromium.org/2472223002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/arc_support/background.js:519: if (pageDivId
== 'lso-loading') {
Are this and L528 also candidates for splitting?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages