Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: content/browser/indexed_db/indexed_db_factory_unittest.cc

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_factory_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_unittest.cc b/content/browser/indexed_db/indexed_db_factory_unittest.cc
index 24c25bf83a5b9d68b07280049d577a7f892a42c9..64940176b140ea25369e8e4904c609df434b195b 100644
--- a/content/browser/indexed_db/indexed_db_factory_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_factory_unittest.cc
@@ -469,7 +469,7 @@ TEST_F(IndexedDBFactoryTest, DatabaseFailedOpen) {
// Open at version 2, then close.
{
- scoped_refptr<MockIndexedDBCallbacks> callbacks(
+ scoped_refptr<UpgradeNeededCallbacks> callbacks(
new UpgradeNeededCallbacks());
std::unique_ptr<IndexedDBPendingConnection> connection(
base::MakeUnique<IndexedDBPendingConnection>(
@@ -483,7 +483,8 @@ TEST_F(IndexedDBFactoryTest, DatabaseFailedOpen) {
// Pump the message loop so the upgrade transaction can run.
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(callbacks->connection());
- callbacks->connection()->database()->Commit(transaction_id);
+ callbacks->connection()->database()->Commit(
+ callbacks->connection()->GetTransaction(transaction_id));
callbacks->connection()->Close();
EXPECT_FALSE(factory()->IsDatabaseOpen(origin, db_name));

Powered by Google App Engine
This is Rietveld 408576698