Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: content/browser/indexed_db/indexed_db_dispatcher_host.h

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_dispatcher_host.h
diff --git a/content/browser/indexed_db/indexed_db_dispatcher_host.h b/content/browser/indexed_db/indexed_db_dispatcher_host.h
index 28f19668fbf9aaef8cf2368f7c0aa61b51b5627a..33a55d7417bf373d67f0bd77ac1a2b24dc31e227 100644
--- a/content/browser/indexed_db/indexed_db_dispatcher_host.h
+++ b/content/browser/indexed_db/indexed_db_dispatcher_host.h
@@ -21,7 +21,6 @@
#include "content/public/browser/browser_message_filter.h"
#include "net/url_request/url_request_context_getter.h"
#include "storage/browser/blob/blob_data_handle.h"
-#include "url/gurl.h"
namespace url {
class Origin;
@@ -50,8 +49,6 @@ class IndexedDBDispatcherHost
void OnDestruct() const override;
bool OnMessageReceived(const IPC::Message& message) override;
- void FinishTransaction(int64_t host_transaction_id, bool committed);
-
// A shortcut for accessing our context.
IndexedDBContextImpl* context() const { return indexed_db_context_.get(); }
storage::BlobStorageContext* blob_storage_context() const {
@@ -59,23 +56,6 @@ class IndexedDBDispatcherHost
}
int ipc_process_id() const { return ipc_process_id_; }
- bool RegisterTransactionId(int64_t host_transaction_id,
- const url::Origin& origin);
- bool GetTransactionSize(int64_t host_transaction_id,
- int64_t* transaction_size);
- void AddToTransaction(int64_t host_transaction_id, int64_t value_length);
-
- // These are called to map a 32-bit front-end (renderer-specific) transaction
- // id to and from a back-end ("host") transaction id that encodes the process
- // id in the high 32 bits. The mapping is host-specific and ids are validated.
- int64_t HostTransactionId(int64_t transaction_id);
- int64_t RendererTransactionId(int64_t host_transaction_id);
-
- // These are called to decode a host transaction ID, for diagnostic purposes.
- static uint32_t TransactionIdToRendererTransactionId(
- int64_t host_transaction_id);
- static uint32_t TransactionIdToProcessId(int64_t host_transaction_id);
-
std::string HoldBlobData(const IndexedDBBlobInfo& blob_info);
void DropBlobData(const std::string& uuid);
@@ -88,10 +68,6 @@ class IndexedDBDispatcherHost
friend class BrowserThread;
friend class base::DeleteHelper<IndexedDBDispatcherHost>;
- // Used in nested classes.
- typedef std::map<int64_t, int64_t> TransactionIDToSizeMap;
- typedef std::map<int64_t, url::Origin> TransactionIDToOriginMap;
-
~IndexedDBDispatcherHost() override;
// indexed_db::mojom::Factory implementation:
@@ -138,8 +114,6 @@ class IndexedDBDispatcherHost
// Only access on IndexedDB thread.
bool is_open_ = true;
- TransactionIDToSizeMap transaction_size_map_;
- TransactionIDToOriginMap transaction_origin_map_;
// Used to set file permissions for blob storage.
int ipc_process_id_;

Powered by Google App Engine
This is Rietveld 408576698