Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: content/browser/indexed_db/indexed_db_callbacks.cc

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: rebased & working Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_callbacks.cc
diff --git a/content/browser/indexed_db/indexed_db_callbacks.cc b/content/browser/indexed_db/indexed_db_callbacks.cc
index 03dd974f2b5211d1ce8c10a172b9d6c3b4520ccf..d59805c3e5149651f9181118328f34b606c809de 100644
--- a/content/browser/indexed_db/indexed_db_callbacks.cc
+++ b/content/browser/indexed_db/indexed_db_callbacks.cc
@@ -23,6 +23,7 @@
#include "content/browser/indexed_db/indexed_db_database_error.h"
#include "content/browser/indexed_db/indexed_db_return_value.h"
#include "content/browser/indexed_db/indexed_db_tracing.h"
+#include "content/browser/indexed_db/indexed_db_transaction.h"
#include "content/browser/indexed_db/indexed_db_value.h"
#include "content/common/indexed_db/indexed_db_constants.h"
#include "content/common/indexed_db/indexed_db_metadata.h"
@@ -215,6 +216,7 @@ void IndexedDBCallbacks::OnBlocked(int64_t existing_version) {
void IndexedDBCallbacks::OnUpgradeNeeded(
int64_t old_version,
std::unique_ptr<IndexedDBConnection> connection,
+ IndexedDBTransaction* transaction,
const IndexedDBDatabaseMetadata& metadata,
const IndexedDBDataLossInfo& data_loss_info) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -225,7 +227,6 @@ void IndexedDBCallbacks::OnUpgradeNeeded(
DCHECK(!database_sent_);
data_loss_ = data_loss_info.status;
- dispatcher_host_->RegisterTransactionId(host_transaction_id_, origin_);
database_sent_ = true;
auto database = base::MakeUnique<DatabaseImpl>(std::move(connection), origin_,
dispatcher_host_);
@@ -278,7 +279,7 @@ void IndexedDBCallbacks::OnSuccess(
}
}
-void IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
+void IndexedDBCallbacks::OnSuccess(std::unique_ptr<IndexedDBCursor> cursor,
const IndexedDBKey& key,
const IndexedDBKey& primary_key,
IndexedDBValue* value) {
@@ -289,8 +290,8 @@ void IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
DCHECK_EQ(kNoTransaction, host_transaction_id_);
DCHECK_EQ(blink::WebIDBDataLossNone, data_loss_);
- auto cursor_impl =
- base::MakeUnique<CursorImpl>(cursor, origin_, dispatcher_host_);
+ auto cursor_impl = base::MakeUnique<CursorImpl>(std::move(cursor), origin_,
+ dispatcher_host_);
::indexed_db::mojom::ValuePtr mojo_value;
std::vector<IndexedDBBlobInfo> blob_info;

Powered by Google App Engine
This is Rietveld 408576698