[IndexedDB] Refactoring to remove ref ptrs and host transaction ids.

content/browser/indexed_db/indexed_db_transaction_coordinator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 
 #include "base/logging.h"
 #include "content/browser/indexed_db/indexed_db_transaction.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
 
 namespace content {
 
 IndexedDBTransactionCoordinator::IndexedDBTransactionCoordinator() {}
 
 IndexedDBTransactionCoordinator::~IndexedDBTransactionCoordinator() {
   DCHECK(queued_transactions_.empty());
   DCHECK(started_transactions_.empty());
 }
 
 void IndexedDBTransactionCoordinator::DidCreateTransaction(
-    scoped_refptr<IndexedDBTransaction> transaction) {
+    IndexedDBTransaction* transaction) {
   DCHECK(!queued_transactions_.count(transaction));
   DCHECK(!started_transactions_.count(transaction));
   DCHECK_EQ(IndexedDBTransaction::CREATED, transaction->state());
 
   queued_transactions_.insert(transaction);
   ProcessQueuedTransactions();
 }
 
 void IndexedDBTransactionCoordinator::DidFinishTransaction(
     IndexedDBTransaction* transaction) {
@@ skipping 26 matching lines @@
     DCHECK(!found);
     found = true;
   }
   return found;
 }
 #endif
 
 std::vector<const IndexedDBTransaction*>
 IndexedDBTransactionCoordinator::GetTransactions() const {
   std::vector<const IndexedDBTransaction*> result;
-
-  for (const auto& transaction : started_transactions_)
-    result.push_back(transaction.get());
-  for (const auto& transaction : queued_transactions_)
-    result.push_back(transaction.get());
-
+  result.reserve(started_transactions_.size() + queued_transactions_.size());
+  result.insert(result.end(), started_transactions_.begin(),

[sof, 2016/12/05 20:00:20]

Somewhat odd, but I'm running into compilation breakage with the use of these
list_set<> iterators in insert():

In file included from
../../content/browser/indexed_db/indexed_db_transaction_coordinator.cc:5:
In file included from
../../content/browser/indexed_db/indexed_db_transaction_coordinator.h:10:
In file included from
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/map:60:
In file included from
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/bits/stl_tree.h:63:
In file included from
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/bits/stl_algobase.h:69:
In file included from
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/debug.h:138:
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/functions.h:137:61:
error: indirection requires pointer operand ('const
list_set<content::IndexedDBTransaction *>::const_iterator' invalid)
      return __foreign_iterator_aux4(__it, std::__addressof(*__other));
                                                            ^~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/functions.h:181:14:
note: in instantiation of function template specialization
'__gnu_debug::__foreign_iterator_aux3<__gnu_cxx::__normal_iterator<const
content::IndexedDBTransaction *const *, std::__cxx1998::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> > >, std::__debug::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> >, list_set<content::IndexedDBTransaction
*>::const_iterator>' requested here
      return __foreign_iterator_aux3(__it, __other, __other_end, __tag());
             ^
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/functions.h:201:5:
note: in instantiation of function template specialization
'__gnu_debug::__foreign_iterator_aux2<__gnu_cxx::__normal_iterator<const
content::IndexedDBTransaction *const *, std::__cxx1998::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> > >, std::__debug::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> >, list_set<content::IndexedDBTransaction
*>::const_iterator>' requested here
        || __foreign_iterator_aux2(__it, std::__miter_base(__other),
           ^
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/functions.h:212:14:
note: in instantiation of function template specialization
'__gnu_debug::__foreign_iterator_aux<__gnu_cxx::__normal_iterator<const
content::IndexedDBTransaction *const *, std::__cxx1998::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> > >, std::__debug::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> >, list_set<content::IndexedDBTransaction
*>::const_iterator>' requested here
      return __foreign_iterator_aux(__it, __other, __other_end, _Integral());
             ^
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/vector:587:4:
note: in instantiation of function template specialization
'__gnu_debug::__foreign_iterator<__gnu_cxx::__normal_iterator<const
content::IndexedDBTransaction *const *, std::__cxx1998::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> > >, std::__debug::vector<const
content::IndexedDBTransaction *, std::allocator<const
content::IndexedDBTransaction *> >, list_set<content::IndexedDBTransaction
*>::const_iterator>' requested here
          __glibcxx_check_insert_range(__position, __first, __last, __dist);
          ^
/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/debug/macros.h:116:36:
note: expanded from macro '__glibcxx_check_insert_range'
_GLIBCXX_DEBUG_VERIFY(__gnu_debug::__foreign_iterator(_Position,_First,_Last),
                                   ^
../../content/browser/indexed_db/indexed_db_transaction_coordinator.cc:69:10:
note: in instantiation of function template specialization
'std::__debug::vector<const content::IndexedDBTransaction *,
std::allocator<const content::IndexedDBTransaction *>
>::insert<list_set<content::IndexedDBTransaction *>::const_iterator, void>'
requested here
  result.insert(result.end(), started_transactions_.begin(),
         ^
1 error generated.
ninja: build stopped: subcommand failed.

Same happens with the g++ 4.9 STL headers on a different workstation (both with
the default is_clang=true) -- no one else has reported similar issues and/or
known cause?

[jsbell, 2016/12/06 00:00:47]

Weird - I haven't heard any other reports. 

list_set isn't too fancy - fixes welcome!

+                started_transactions_.end());
+  result.insert(result.end(), queued_transactions_.begin(),
+                queued_transactions_.end());
   return result;
 }
 
 void IndexedDBTransactionCoordinator::ProcessQueuedTransactions() {
   if (queued_transactions_.empty())
     return;
 
   DCHECK(!IsRunningVersionChangeTransaction());
 
   // The locked_scope set accumulates the ids of object stores in the scope of
   // running read/write transactions. Other read-write transactions with
   // stores in this set may not be started. Read-only transactions may start,
   // taking a snapshot of the database, which does not include uncommitted
   // data. ("Version change" transactions are exclusive, but handled by the
   // connection sequencing in IndexedDBDatabase.)
   std::set<int64_t> locked_scope;
   for (const auto& transaction : started_transactions_) {
     if (transaction->mode() == blink::WebIDBTransactionModeReadWrite) {
       // Started read/write transactions have exclusive access to the object
       // stores within their scopes.
       locked_scope.insert(transaction->scope().begin(),
                           transaction->scope().end());
     }
   }
 
   auto it = queued_transactions_.begin();
   while (it != queued_transactions_.end()) {
-    scoped_refptr<IndexedDBTransaction> transaction = *it;
+    IndexedDBTransaction* transaction = *it;
     ++it;
-    if (CanStartTransaction(transaction.get(), locked_scope)) {
+    if (CanStartTransaction(transaction, locked_scope)) {
       DCHECK_EQ(IndexedDBTransaction::CREATED, transaction->state());
       queued_transactions_.erase(transaction);
       started_transactions_.insert(transaction);
       transaction->Start();
       DCHECK_EQ(IndexedDBTransaction::STARTED, transaction->state());
     }
     if (transaction->mode() == blink::WebIDBTransactionModeReadWrite) {
       // Either the transaction started, so it has exclusive access to the
       // stores in its scope, or per the spec the transaction which was
       // created first must get access first, so the stores are also locked.
@@ skipping 32 matching lines @@
 
     case blink::WebIDBTransactionModeReadOnly:
     case blink::WebIDBTransactionModeReadWrite:
       return !DoSetsIntersect(transaction->scope(), locked_scope);
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace content