Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2472193002: [profiler] Introduce lightweight mode for Rutime Call Stats collection. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
lpy, fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Introduce lightweight mode for Rutime Call Stats collection. In the lightweight mode it only maintains pseudo stack and does not collect timing information. It can be used in the sampling mode. BUG=chromium:660428 Committed: https://crrev.com/c57e54b389360b8f46bbf9dcfdc1a3cb3445e7ae Cr-Commit-Position: refs/heads/master@{#40812}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/counters.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/tracing/tracing-category-observer.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M src/tracing/tracing-category-observer.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
4 years, 1 month ago (2016-11-03 23:01:51 UTC) #2
Camillo Bruni
lgtm
4 years, 1 month ago (2016-11-04 10:38:10 UTC) #3
lpy
LGTM.
4 years, 1 month ago (2016-11-04 17:07:48 UTC) #6
fmeawad
lgtm
4 years, 1 month ago (2016-11-04 17:08:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472193002/20001
4 years, 1 month ago (2016-11-07 17:46:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 18:13:36 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c57e54b389360b8f46bbf9dcfdc1a3cb3445e7ae
Cr-Commit-Position: refs/heads/master@{#40812}

Powered by Google App Engine
This is Rietveld 408576698