Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2472183003: Remove linked_ptr from ash (Closed)

Created:
4 years, 1 month ago by limasdf
Modified:
4 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, posciak+watch_chromium.org, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove linked_ptr from ash Use uniqued_ptr instead of deprecated linked_ptr. BUG=556939 Committed: https://crrev.com/4fa33f699f910aee5656a6af311ad6b6ea7c3e13 Cr-Commit-Position: refs/heads/master@{#430155}

Patch Set 1 #

Total comments: 5

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M ash/first_run/desktop_cleaner.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/first_run/desktop_cleaner.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_shadow_controller.h View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/resize_shadow_controller.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M ash/wm/video_detector.h View 1 4 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
limasdf
Hi Oshima, could you take a look at this clean up
4 years, 1 month ago (2016-11-04 17:27:53 UTC) #5
oshima
lgtm https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc File ash/wm/resize_shadow_controller.cc (right): https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc#newcode53 ash/wm/resize_shadow_controller.cc:53: std::unique_ptr<ResizeShadow> shadow(new ResizeShadow()); optional: or auto..MakeUnique. https://codereview.chromium.org/2472183003/diff/20001/ash/wm/video_detector.h File ...
4 years, 1 month ago (2016-11-04 18:31:43 UTC) #6
limasdf
Thanks for the review. one question on the your comment https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc File ash/wm/resize_shadow_controller.cc (right): https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc#newcode53 ...
4 years, 1 month ago (2016-11-05 06:08:17 UTC) #7
limasdf
https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc File ash/wm/resize_shadow_controller.cc (right): https://codereview.chromium.org/2472183003/diff/20001/ash/wm/resize_shadow_controller.cc#newcode53 ash/wm/resize_shadow_controller.cc:53: std::unique_ptr<ResizeShadow> shadow(new ResizeShadow()); On 2016/11/05 06:08:17, limasdf wrote: > ...
4 years, 1 month ago (2016-11-05 06:12:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472183003/40001
4 years, 1 month ago (2016-11-05 06:13:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-05 06:56:45 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 06:58:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fa33f699f910aee5656a6af311ad6b6ea7c3e13
Cr-Commit-Position: refs/heads/master@{#430155}

Powered by Google App Engine
This is Rietveld 408576698