Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2472173002: DXVA: Add --disable-low-latency-dxva to disable low latency decoding (Closed)

Created:
4 years, 1 month ago by sandersd (OOO until July 31)
Modified:
4 years, 1 month ago
Reviewers:
jbauman, dcheng, piman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DXVA: Add --disable-low-latency-dxva to disable low latency decoding BUG=625011 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/57d5eddcbc0407ee50a2b63acc3eac5ffb4f27cc Cr-Commit-Position: refs/heads/master@{#430439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : IPC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M content/common/gpu_host_messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/gpu_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_preferences.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
sandersd (OOO until July 31)
Investigatory feature for crbug.com/625011: theory is that this is the main difference between our stack ...
4 years, 1 month ago (2016-11-03 19:15:21 UTC) #3
jbauman
lgtm
4 years, 1 month ago (2016-11-07 20:01:26 UTC) #4
sandersd (OOO until July 31)
piman@chromium.org: Please review changes in content/public.
4 years, 1 month ago (2016-11-07 20:05:29 UTC) #6
piman
https://codereview.chromium.org/2472173002/diff/1/gpu/command_buffer/service/gpu_preferences.h File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2472173002/diff/1/gpu/command_buffer/service/gpu_preferences.h#newcode65 gpu/command_buffer/service/gpu_preferences.h:65: bool enable_low_latency_dxva = true; You need to add this ...
4 years, 1 month ago (2016-11-07 20:40:14 UTC) #7
sandersd (OOO until July 31)
https://codereview.chromium.org/2472173002/diff/1/gpu/command_buffer/service/gpu_preferences.h File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2472173002/diff/1/gpu/command_buffer/service/gpu_preferences.h#newcode65 gpu/command_buffer/service/gpu_preferences.h:65: bool enable_low_latency_dxva = true; On 2016/11/07 20:40:14, piman wrote: ...
4 years, 1 month ago (2016-11-07 20:43:39 UTC) #8
piman
LGTM, +dcheng for trivial addition to content/common/gpu_host_messages.h
4 years, 1 month ago (2016-11-07 20:45:35 UTC) #10
dcheng
rs lgtm
4 years, 1 month ago (2016-11-07 20:51:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472173002/20001
4 years, 1 month ago (2016-11-07 23:49:29 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 00:29:25 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:33:25 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57d5eddcbc0407ee50a2b63acc3eac5ffb4f27cc
Cr-Commit-Position: refs/heads/master@{#430439}

Powered by Google App Engine
This is Rietveld 408576698