chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 2472163003: [CustomTabs] Report the navigation start as absolute time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2472163003: [CustomTabs] Report the navigation start as absolute time (Closed)

Patch Set: Cache tick offset Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/time_utils.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index 20c8cd28cc90f3ce882345c2d8e3fba11140e9fc..2bb8fcdf6ac225dbcf7d8f2230c3ed8f8f12394a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -130,11 +130,12 @@ public class CustomTabActivity extends ChromeActivity {

}

@Override

- public void onFirstContentfulPaint(WebContents webContents, long firstContentfulPaintMs) {

+ public void onFirstContentfulPaint(

+ WebContents webContents, long navigationStartTick, long firstContentfulPaintMs) {

if (webContents != mTab.getWebContents()) return;

- mConnection.notifyPageLoadMetric(

- mSession, PageLoadMetrics.FIRST_CONTENTFUL_PAINT, firstContentfulPaintMs);

+ mConnection.notifyPageLoadMetric(mSession, PageLoadMetrics.FIRST_CONTENTFUL_PAINT,

+ navigationStartTick, firstContentfulPaintMs);

}