Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 2472153002: Gathering information about test filter files into a README.md file. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gathering information about test filter files into a README.md file. BUG= Committed: https://crrev.com/f2fe3f73193ff110e2e3ae6e5357d1dfe01d9905 Cr-Commit-Position: refs/heads/master@{#430623}

Patch Set 1 #

Patch Set 2 : Extracted behavioral changes into a separate CL. #

Patch Set 3 : Self-review. #

Total comments: 8

Patch Set 4 : Addressed CR feedback from alexmos@. #

Patch Set 5 : Updated README.md to match changes made in https://crrev.com/2469353002. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M base/test/launcher/test_launcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download
A testing/buildbot/filters/README.md View 1 2 3 4 1 chunk +85 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (12 generated)
Łukasz Anforowicz
alexmos@, can you take a look please?
4 years, 1 month ago (2016-11-03 18:13:46 UTC) #3
alexmos
Thanks a lot for writing this all out! LGTM with nits. https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filters/README.md File testing/buildbot/filters/README.md (right): ...
4 years, 1 month ago (2016-11-03 21:30:59 UTC) #4
Łukasz Anforowicz
Thanks for the review. https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filters/README.md File testing/buildbot/filters/README.md (right): https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filters/README.md#newcode19 testing/buildbot/filters/README.md:19: - All other patterns specify ...
4 years, 1 month ago (2016-11-03 22:00:15 UTC) #5
Łukasz Anforowicz
jbudorick@ + phajdan.jr@, could you PTAL? phajdan.jr@: base/test/launcher/test_launcher.cc base/test/launcher/unit_test_launcher.cc jbudorick@: build/android/test_runner.py (thank you for already ...
4 years, 1 month ago (2016-11-03 22:02:50 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 1 month ago (2016-11-04 07:14:58 UTC) #8
jbudorick
build/android/ lgtm
4 years, 1 month ago (2016-11-04 13:08:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472153002/80001
4 years, 1 month ago (2016-11-08 14:11:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/331056)
4 years, 1 month ago (2016-11-08 14:52:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472153002/80001
4 years, 1 month ago (2016-11-08 15:18:32 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 15:47:25 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 15:52:44 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f2fe3f73193ff110e2e3ae6e5357d1dfe01d9905
Cr-Commit-Position: refs/heads/master@{#430623}

Powered by Google App Engine
This is Rietveld 408576698