Gathering information about test filter files into a README.md file.

Gathering information about test filter files into a README.md file.

BUG=

Committed: https://crrev.com/f2fe3f73193ff110e2e3ae6e5357d1dfe01d9905
Cr-Commit-Position: refs/heads/master@{#430623}

[Łukasz Anforowicz, 2016-11-03 17:35:07]

Description was changed from

==========
Gathering information about test filter files into a README.md file.

When authoring the README.md file, I've noticed that test_runner.py
doesn't properly handle negative patterns from the filter files.
I've fixed this and added some unit tests around this.  The changes
are based on the understanding of the desired format of --gtest_filter
that is based on

1) the format used in chromium.fyi.json prior to introducing
   testing/buildbot/filters directory - for example notice multiple
   patterns, but only a single '-' character in:
https://chromium.googlesource.com/chromium/src/+/e443d6647254776e868dce6a5964...

2) gtest documentation at
https://github.com/google/googletest/blob/master/googletest/docs/AdvancedGuid...

BUG=
==========

to

==========
Gathering information about test filter files into a README.md file.

BUG=
==========

[Łukasz Anforowicz, 2016-11-03 18:13:45]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org

[Łukasz Anforowicz, 2016-11-03 18:13:46]

alexmos@, can you take a look please?

[alexmos, 2016-11-03 21:30:59]

Thanks a lot for writing this all out!  LGTM with nits.

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
File testing/buildbot/filters/README.md (right):

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:19: -   All other patterns specify tests to
include in a test run.
nit: while we're at it, should we also warn about what happens if both are
specified? (I.e., that if any positive patterns are specified, the negative
patterns only apply to that set and not the full set of tests, which is probably
not what you want?)

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:61: For excluding layout tests for specific
command line flags of `content_shell`,
nit: maybe simplify to "For excluding layout tests when running with a
particular command line flag, see..."?

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:68: Please use the following suggestions when
naming the new file:
how about s/suggestions/conventions/ :)

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:72: -   Please use `.filter` suffix /
extension.
nit: "suffix / extension" - just pick one?

[Łukasz Anforowicz, 2016-11-03 22:00:15]

Thanks for the review.

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
File testing/buildbot/filters/README.md (right):

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:19: -   All other patterns specify tests to
include in a test run.
On 2016/11/03 21:30:58, alexmos wrote:
> nit: while we're at it, should we also warn about what happens if both are
> specified? (I.e., that if any positive patterns are specified, the negative
> patterns only apply to that set and not the full set of tests, which is
probably
> not what you want?)

Done.  Sort of (no warning, just copying the short explanation from gtest docs; 
for good measure I did include the link to the controversal gtest_filter VS
test-launcher-filter-file bug).

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:61: For excluding layout tests for specific
command line flags of `content_shell`,
On 2016/11/03 21:30:58, alexmos wrote:
> nit: maybe simplify to "For excluding layout tests when running with a
> particular command line flag, see..."?

Done.

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:68: Please use the following suggestions when
naming the new file:
On 2016/11/03 21:30:58, alexmos wrote:
> how about s/suggestions/conventions/ :)

Done.

https://codereview.chromium.org/2472153002/diff/40001/testing/buildbot/filter...
testing/buildbot/filters/README.md:72: -   Please use `.filter` suffix /
extension.
On 2016/11/03 21:30:58, alexmos wrote:
> nit: "suffix / extension" - just pick one?

Done.

[Łukasz Anforowicz, 2016-11-03 22:02:50]

lukasza@chromium.org changed reviewers:
+ jbudorick@chromium.org, phajdan.jr@chromium.org

[Łukasz Anforowicz, 2016-11-03 22:02:50]

jbudorick@ + phajdan.jr@, could you PTAL?

phajdan.jr@:
    base/test/launcher/test_launcher.cc
    base/test/launcher/unit_test_launcher.cc

jbudorick@:
    build/android/test_runner.py
(thank you for already taking a look at https://crrev.com/2477813002 :-)

[Paweł Hajdan Jr., 2016-11-04 07:14:58]

LGTM

[jbudorick, 2016-11-04 13:08:37]

build/android/ lgtm

[Łukasz Anforowicz, 2016-11-04 15:10:05]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 15:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 16:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:37:47]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-11-08 14:11:22]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-11-08 14:11:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexmos@chromium.org, jbudorick@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2472153002/#ps80001
(title: "Updated README.md to match changes made in
https://crrev.com/2469353002.")

[commit-bot: I haz the power, 2016-11-08 14:11:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:52:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-11-08 15:18:19]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:18:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:47:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-08 15:52:43]

Description was changed from

==========
Gathering information about test filter files into a README.md file.

BUG=
==========

to

==========
Gathering information about test filter files into a README.md file.

BUG=

Committed: https://crrev.com/f2fe3f73193ff110e2e3ae6e5357d1dfe01d9905
Cr-Commit-Position: refs/heads/master@{#430623}
==========

[commit-bot: I haz the power, 2016-11-08 15:52:44]

Patchset 5 (id:??) landed as
https://crrev.com/f2fe3f73193ff110e2e3ae6e5357d1dfe01d9905
Cr-Commit-Position: refs/heads/master@{#430623}