Issue 2472143002: [modules] Disable Crankshaft for functions referencing module variables.

Issue 2472143002: [modules] Disable Crankshaft for functions referencing module variables. (Closed)

Created:
4 years, 1 month ago by neis

Modified:
4 years, 1 month ago

Reviewers:
Michael Starzinger, adamk

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[modules] Disable Crankshaft for functions referencing module variables. Also add a primitive mjsunit test that uses such a function optimized by Turbofan. R=mstarzinger@chromium.org CC=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/cc3195abda56e56b05cf92c41b493055e9ba52ad Cr-Commit-Position: refs/heads/master@{#40826}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -9 lines)			Patch
M	src/ast/ast-numbering.cc	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/bailout-reason.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/modules-turbo.js	View	1 chunk	+5 lines, -7 lines	0 comments	Download

Depends on Patchset:

Total messages: 9 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472143002/1

4 years, 1 month ago (2016-11-08 11:17:32 UTC) #6

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:25:49 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cc3195abda56e56b05cf92c41b493055e9ba52ad
Cr-Commit-Position: refs/heads/master@{#40826}