Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2472133004: Creating class for processing of keypress events. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index 1f9cbdcc4a777617bcef6a9665777d444d3d942e..024db49f5114f8e9a0184b4691d065441652619f 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -15,8 +15,10 @@
#include "components/password_manager/content/browser/credential_manager_impl.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_manager_client.h"
+#include "components/password_manager/core/browser/password_reuse_detection_manager.h"
#include "components/password_manager/sync/browser/sync_credentials_filter.h"
#include "components/prefs/pref_member.h"
+#include "content/public/browser/render_widget_host.h"
#include "content/public/browser/web_contents_binding_set.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -38,7 +40,8 @@ class ChromePasswordManagerClient
: public password_manager::PasswordManagerClient,
public content::WebContentsObserver,
public content::WebContentsUserData<ChromePasswordManagerClient>,
- public autofill::mojom::PasswordManagerClient {
+ public autofill::mojom::PasswordManagerClient,
+ public content::RenderWidgetHost::InputEventObserver {
public:
~ChromePasswordManagerClient() override;
@@ -122,6 +125,12 @@ class ChromePasswordManagerClient
// content::WebContentsObserver overrides.
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
+ void DidNavigateMainFrame(
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) override;
+
+ // content::RenderWidgetHost::InputEventObserver overrides.
+ void OnInputEvent(const blink::WebInputEvent&) override;
// Given |bounds| in the renderers coordinate system, return the same bounds
// in the screens coordinate system.
@@ -152,6 +161,9 @@ class ChromePasswordManagerClient
password_manager::PasswordManager password_manager_;
+ password_manager::PasswordReuseDetectionManager
+ password_reuse_detection_manager_;
+
password_manager::ContentPasswordManagerDriverFactory* driver_factory_;
// As a mojo service, will be registered into service registry
@@ -166,8 +178,8 @@ class ChromePasswordManagerClient
autofill::PasswordGenerationPopupObserver* observer_;
// Controls the popup
- base::WeakPtr<
- autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
+ base::WeakPtr<autofill::PasswordGenerationPopupControllerImpl>
vabr (Chromium) 2016/12/23 17:14:11 nit: Unless the tools force you to do this change,
dvadym 2016/12/23 17:45:20 Done.
+ popup_controller_;
// Set to false to disable password saving (will no longer ask if you
// want to save passwords and also won't fill the passwords).

Powered by Google App Engine
This is Rietveld 408576698