Creating class for processing of keypress events.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 126 matching lines @@
       UserDataKey(),
       new ChromePasswordManagerClient(contents, autofill_client));
 }
 
 ChromePasswordManagerClient::ChromePasswordManagerClient(
     content::WebContents* web_contents,
     autofill::AutofillClient* autofill_client)
     : content::WebContentsObserver(web_contents),
       profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
       password_manager_(this),
+      password_reuse_detection_manager_(this),
       driver_factory_(nullptr),
       credential_manager_impl_(web_contents, this),
       password_manager_client_bindings_(web_contents, this),
       observer_(nullptr),
       credentials_filter_(this,
                           base::Bind(&GetSyncService, profile_),
                           base::Bind(&GetSigninManager, profile_)) {
   ContentPasswordManagerDriverFactory::CreateForWebContents(web_contents, this,
                                                             autofill_client);
   driver_factory_ =
@@ skipping 91 matching lines @@
   }
 #else
   if (form_to_save->IsBlacklisted())
     return false;
 
   if (update_password) {
     UpdatePasswordInfoBarDelegate::Create(web_contents(),
                                           std::move(form_to_save));
     return true;
   }
-  SavePasswordInfoBarDelegate::Create(web_contents(),
-                                      std::move(form_to_save));
+  SavePasswordInfoBarDelegate::Create(web_contents(), std::move(form_to_save));
 #endif  // !BUILDFLAG(ANDROID_JAVA_UI)
   return true;
 }
 
 bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
     std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
     const GURL& origin,
     const CredentialsCallback& callback) {
   // Set up an intercept callback if the prompt is zero-clickable (e.g. just one
   // form provided).
@@ skipping 100 matching lines @@
   manage_passwords_ui_controller->OnPasswordAutofilled(best_matches, origin,
                                                        federated_matches);
 #endif
 }
 
 void ChromePasswordManagerClient::HidePasswordGenerationPopup() {
   if (popup_controller_)
     popup_controller_->HideAndDestroy();
 }
 
+void ChromePasswordManagerClient::DidNavigateMainFrame(
+    const content::LoadCommittedDetails& details,
+    const content::FrameNavigateParams& params) {
+  password_reuse_detection_manager_.DidNavigateMainFrame();
+  web_contents()->GetRenderViewHost()->GetWidget()->RemoveInputEventObserver(

[vabr (Chromium), 2016/12/23 17:14:10]

Why is it needed to remove and immediately add itself as an observer? (Please
also comment in the code.)

[dvadym, 2016/12/23 17:45:20]

I've added a comment with explanation.

[vabr (Chromium), 2016/12/23 21:24:24]

Acknowledged.

+      this);
+  web_contents()->GetRenderViewHost()->GetWidget()->AddInputEventObserver(this);
+}
+
+void ChromePasswordManagerClient::OnInputEvent(
+    const blink::WebInputEvent& event) {
+  if (event.type != blink::WebInputEvent::Char)
+    return;
+  const blink::WebKeyboardEvent& key_event =
+      static_cast<const blink::WebKeyboardEvent&>(event);
+  password_reuse_detection_manager_.OnKeyPressed(key_event.text);
+}
+
 PrefService* ChromePasswordManagerClient::GetPrefs() {
   return profile_->GetPrefs();
 }
 
-password_manager::PasswordStore*
-ChromePasswordManagerClient::GetPasswordStore() const {
+password_manager::PasswordStore* ChromePasswordManagerClient::GetPasswordStore()

[vabr (Chromium), 2016/12/23 17:14:10]

nit: Also here and on lines 408-409, please revert the unrelated changes, to
keep git history clear.

[dvadym, 2016/12/23 17:45:20]

Done.

+    const {
   // Always use EXPLICIT_ACCESS as the password manager checks IsOffTheRecord
   // itself when it shouldn't access the PasswordStore.
   // TODO(gcasto): Is is safe to change this to
   // ServiceAccessType::IMPLICIT_ACCESS?
-  return PasswordStoreFactory::GetForProfile(
-             profile_, ServiceAccessType::EXPLICIT_ACCESS).get();
+  return PasswordStoreFactory::GetForProfile(profile_,
+             ServiceAccessType::EXPLICIT_ACCESS).get();
 }
 
 password_manager::PasswordSyncState
 ChromePasswordManagerClient::GetPasswordSyncState() const {
   const browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile_);
   return password_manager_util::GetPasswordSyncState(sync_service);
 }
 
 bool ChromePasswordManagerClient::WasLastNavigationHTTPError() const {
   DCHECK(web_contents());
 
   std::unique_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
   if (log_manager_->IsLoggingActive()) {
     logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
         log_manager_.get()));
-    logger->LogMessage(
-        Logger::STRING_WAS_LAST_NAVIGATION_HTTP_ERROR_METHOD);
+    logger->LogMessage(Logger::STRING_WAS_LAST_NAVIGATION_HTTP_ERROR_METHOD);
   }
 
   content::NavigationEntry* entry =
       web_contents()->GetController().GetVisibleEntry();
   if (!entry)
     return false;
   int http_status_code = entry->GetHttpStatusCode();
 
   if (logger)
     logger->LogNumber(Logger::STRING_HTTP_STATUS_CODE, http_status_code);
@@ skipping 193 matching lines @@
       ChromePasswordManagerClient::FromWebContents(web_contents);
 
   // Try to bind to the driver, but if driver is not available for this render
   // frame host, the request will be just dropped. This will cause the message
   // pipe to be closed, which will raise a connection error on the peer side.
   if (!instance)
     return;
 
   instance->credential_manager_impl_.BindRequest(std::move(request));
 }