Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chromecast/browser/devtools/remote_debugging_server.cc

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Android browser added Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/devtools/DEPS ('k') | content/browser/devtools/devtools_http_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/devtools/remote_debugging_server.cc
diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc
index bf2681dce06107a7f978b33cc3b84fdd13208172..280aff83ab091a88b4d551a2a18dd0c56dc3c997 100644
--- a/chromecast/browser/devtools/remote_debugging_server.cc
+++ b/chromecast/browser/devtools/remote_debugging_server.cc
@@ -25,6 +25,7 @@
#include "net/base/net_errors.h"
#include "net/log/net_log_source.h"
#include "net/socket/tcp_server_socket.h"
+#include "v8/include/v8.h"
#if defined(OS_ANDROID)
#include "content/public/browser/android/devtools_auth.h"
@@ -163,7 +164,8 @@ void RemoteDebuggingServer::OnEnabledChanged() {
base::FilePath(),
base::FilePath(),
std::string(),
- GetUserAgent());
+ GetUserAgent(),
+ v8::V8::GetVersion());
LOG(INFO) << "Devtools started: port=" << port_;
} else if (!enabled && is_started_) {
LOG(INFO) << "Stop devtools: port=" << port_;
« no previous file with comments | « chromecast/browser/devtools/DEPS ('k') | content/browser/devtools/devtools_http_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698