Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: chrome/browser/android/devtools_server.cc

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Android browser added Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_devtools_server.cc ('k') | chrome/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/devtools_server.cc
diff --git a/chrome/browser/android/devtools_server.cc b/chrome/browser/android/devtools_server.cc
index 56c47367c7cf3280a8f85160a4f9d10ae8996672..f5450e52b175e0bf4c3fa4c0fa9165170c89fb92 100644
--- a/chrome/browser/android/devtools_server.cc
+++ b/chrome/browser/android/devtools_server.cc
@@ -44,6 +44,7 @@
#include "net/base/net_errors.h"
#include "net/socket/unix_domain_server_socket_posix.h"
#include "net/url_request/url_request_context_getter.h"
+#include "v8/include/v8.h"
using base::android::JavaParamRef;
using content::DevToolsAgentHost;
@@ -160,7 +161,8 @@ void DevToolsServer::Start(bool allow_debug_permission) {
std::move(factory),
base::StringPrintf(kFrontEndURL, content::GetWebKitRevision().c_str()),
base::FilePath(), base::FilePath(),
- version_info::GetProductNameAndVersionForUserAgent(), ::GetUserAgent());
+ version_info::GetProductNameAndVersionForUserAgent(), ::GetUserAgent().
+ v8::V8::GetVersion());
is_started_ = true;
}
« no previous file with comments | « android_webview/native/aw_devtools_server.cc ('k') | chrome/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698