Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4530)

Unified Diff: chrome/browser/resources/settings/settings_vars_css.html

Issue 2472083003: Increase .settings-box and .settigns-box.two-line height. (Closed)
Patch Set: added comments to differentiate different height css variables Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_vars_css.html
diff --git a/chrome/browser/resources/settings/settings_vars_css.html b/chrome/browser/resources/settings/settings_vars_css.html
index 326fa31ba84c209ccdc57b59a9f426dd73da6ea2..a409623e40b6c1734f2c0937b29c257c54e4082b 100644
--- a/chrome/browser/resources/settings/settings_vars_css.html
+++ b/chrome/browser/resources/settings/settings_vars_css.html
@@ -33,8 +33,14 @@
--settings-page-vertical-margin: 21px;
+ /* These are used for row items such as radio buttons, check boxes, list items etc */
Dan Beam 2016/11/03 23:06:57 this should wrap at 80 cols
scottchen 2016/11/04 00:07:24 Done. Nice catch.
--settings-row-min-height: 44px;
--settings-row-two-line-min-height: 56px;
+
+ /* These are used for the settings-box containers, which may contain one or more "row items" */
+ --settings-box-min-height: 48px;
+ --settings-box-two-line-min-height: 60px;
+
--settings-secondary: {
color: var(--paper-grey-600);
font-weight: 400;
« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698