Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/resources/settings/settings_vars_css.html

Issue 2472083003: Increase .settings-box and .settigns-box.two-line height. (Closed)
Patch Set: reverted the original height for .two-line and added a more specific .settings-box.two-line rule Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html"> 1 <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">
3 3
4 <!-- Common css variables for Material Design settings. --> 4 <!-- Common css variables for Material Design settings. -->
5 <style is="custom-style"> 5 <style is="custom-style">
6 /* We keep our vars in sort order, though some vars must be defined prior to 6 /* We keep our vars in sort order, though some vars must be defined prior to
7 * others. The --settings-* vars are defined explicitly prior to the --paper-* 7 * others. The --settings-* vars are defined explicitly prior to the --paper-*
8 * and --iron-* vars. 8 * and --iron-* vars.
9 */ 9 */
10 :root { 10 :root {
(...skipping 14 matching lines...) Expand all
25 --settings-list-frame-padding: { 25 --settings-list-frame-padding: {
26 -webkit-padding-end: var(--settings-box-row-padding); 26 -webkit-padding-end: var(--settings-box-row-padding);
27 -webkit-padding-start: 56px; 27 -webkit-padding-start: 56px;
28 padding-bottom: 0; 28 padding-bottom: 0;
29 padding-top: 0; 29 padding-top: 0;
30 } 30 }
31 31
32 --settings-nav-grey: rgb(90, 90, 90); 32 --settings-nav-grey: rgb(90, 90, 90);
33 33
34 --settings-page-vertical-margin: 21px; 34 --settings-page-vertical-margin: 21px;
35 35
dpapad 2016/11/03 22:33:28 Perhaps worth adding a comment that those are used
scottchen 2016/11/03 22:39:28 Acknowledged.
scottchen 2016/11/03 22:39:45 Done.
36 --settings-row-min-height: 44px; 36 --settings-row-min-height: 44px;
37 --settings-row-two-line-min-height: 56px; 37 --settings-row-two-line-min-height: 56px;
38
39 --settings-box-min-height: 48px;
40 --settings-box-two-line-min-height: 60px;
41
38 --settings-secondary: { 42 --settings-secondary: {
39 color: var(--paper-grey-600); 43 color: var(--paper-grey-600);
40 font-weight: 400; 44 font-weight: 400;
41 margin-top: 4px; 45 margin-top: 4px;
42 }; 46 };
43 --settings-separator-line: var(--cr-separator-line); 47 --settings-separator-line: var(--cr-separator-line);
44 48
45 --settings-title-bar-background-color: var(--google-blue-700); 49 --settings-title-bar-background-color: var(--google-blue-700);
46 --settings-title-bar-color: rgb(255, 255, 255); 50 --settings-title-bar-color: rgb(255, 255, 255);
47 --settings-title-search-color: rgb(192, 199, 205); 51 --settings-title-search-color: rgb(192, 199, 205);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 --paper-toggle-button-checked-button: { 92 --paper-toggle-button-checked-button: {
89 @apply(--settings-toggle-button-size); 93 @apply(--settings-toggle-button-size);
90 transform: translate(14px, 0); 94 transform: translate(14px, 0);
91 }; 95 };
92 --paper-toggle-button-checked-button-color: var(--settings-toggle-color); 96 --paper-toggle-button-checked-button-color: var(--settings-toggle-color);
93 --paper-toggle-button-label-spacing: 0; 97 --paper-toggle-button-label-spacing: 0;
94 --paper-toggle-button-unchecked-bar: var(--settings-toggle-bar-size); 98 --paper-toggle-button-unchecked-bar: var(--settings-toggle-bar-size);
95 --paper-toggle-button-unchecked-button: var(--settings-toggle-button-size); 99 --paper-toggle-button-unchecked-button: var(--settings-toggle-button-size);
96 } 100 }
97 </style> 101 </style>
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698