Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources is disabled

Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
Committed: https://crrev.com/0b2aeaccf0023facc1ba07bd953f535225138386
Cr-Commit-Position: refs/heads/master@{#430503}

[pkotwicz, 2016-11-04 01:17:50]

Description was changed from

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
==========

to

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
==========

[pkotwicz, 2016-11-04 01:21:50]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-11-04 01:25:05]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-11-04 01:25:06]

Dan, can you please take a look?

- I still need to get approval for the dialog text from Sam.
- I am unsure whether tests for this CL would be useful (If tests would be
useful, what scenario in particular should I test?)

[pkotwicz, 2016-11-04 02:03:42]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-11-04 20:42:11]

dfalcantara@ Ping!

[gone, 2016-11-04 20:52:36]

On 2016/11/04 20:42:11, pkotwicz wrote:
> dfalcantara@ Ping!

Look at my queue and all the CLs that have been active in the last 24 hours :P

[gone, 2016-11-04 22:07:43]

https://codereview.chromium.org/2472073003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2472073003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:389:
if (ChromeVersionInfo.isCanaryBuild() || ChromeVersionInfo.isDevBuild()) {
Move the channel check into #launchWebApkRequirementsDialogIfNeeded() with all
the other checks you're doing.

https://codereview.chromium.org/2472073003/diff/40001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2472073003/diff/40001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:2714: Enabling
"Installation from Untrusted Sources" makes your device more vulnerable. Be sure
to re-enable installation from unknown sources once you are done playing with
the "WebAPK experiment".
1) You don't want users to "re-enable installation from unknown sources"; they
had to turn it on in order to play with WebAPKs.

2) Untrusted or Unknown?  You flip between the two repeatedly in your CL, and
even in this message.  Pick one.

[pkotwicz, 2016-11-05 01:56:45]

Patchset #2 (id:60001) has been deleted

[pkotwicz, 2016-11-05 01:58:57]

Patchset #2 (id:80001) has been deleted

[pkotwicz, 2016-11-05 01:59:14]

Dan can you please take another look?

[gone, 2016-11-07 18:27:13]

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:2720: Turn on “Unknown
sources” in Android security settings to try "Improved Add to Home screen"
experiment in Chrome Dev. Be sure to disable this setting when you’re done
trying it out.
Not much value in differentiating between Canary in Dev in these strings.  Just
make it one string again.

[pkotwicz, 2016-11-07 20:08:13]

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:2720: Turn on “Unknown
sources” in Android security settings to try "Improved Add to Home screen"
experiment in Chrome Dev. Be sure to disable this setting when you’re done
trying it out.
What are you suggesting changing the string to?

[gone, 2016-11-07 20:59:30]

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:2720: Turn on “Unknown
sources” in Android security settings to try "Improved Add to Home screen"
experiment in Chrome Dev. Be sure to disable this setting when you’re done
trying it out.
On 2016/11/07 20:08:13, pkotwicz wrote:
> What are you suggesting changing the string to?

Take out the "Dev"/"Canary" bits, which will collapse both into one string.

[pkotwicz, 2016-11-07 21:09:53]

Done! Dan can you please take another look?

[gone, 2016-11-07 21:12:50]

lgtm because the string is still usable.

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2472073003/diff/120001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:2720: Turn on “Unknown
sources” in Android security settings to try "Improved Add to Home screen"
experiment in Chrome Dev. Be sure to disable this setting when you’re done
trying it out.
On 2016/11/07 20:59:29, dfalcantara (check my queue) wrote:
> On 2016/11/07 20:08:13, pkotwicz wrote:
> > What are you suggesting changing the string to?
> 
> Take out the "Dev"/"Canary" bits, which will collapse both into one string.

I meant to keep Chrome, but to remove the channel.  lgtming this anyway because
the string still works.

[pkotwicz, 2016-11-08 02:29:29]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:34:16]

Description was changed from

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
==========

to

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
==========

[commit-bot: I haz the power, 2016-11-08 03:34:17]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-11-08 03:41:40]

Description was changed from

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712
==========

to

==========
Show AlertDialog when WebAPKs are enabled in chrome://flags but Unknown sources
is disabled

This CL also adds caching for whether the --enable-webapk command line flag is
set. The goal of the caching is to avoid showing the AlertDialog when the
variation state changes

BUG=661712

Committed: https://crrev.com/0b2aeaccf0023facc1ba07bd953f535225138386
Cr-Commit-Position: refs/heads/master@{#430503}
==========

[commit-bot: I haz the power, 2016-11-08 03:41:41]

Patchset 4 (id:??) landed as
https://crrev.com/0b2aeaccf0023facc1ba07bd953f535225138386
Cr-Commit-Position: refs/heads/master@{#430503}