Preparse lazy function parameters

Preparse lazy function parameters

Parameters of a lazily parsed function used to be parsed eagerly, and parameter
handling was split between Parser::ParseFunctionLiteral and
ParseEagerFunctionBody, leading to inconsistencies.

After this CL, we preparse (lazy parse) the parameters of lazily parsed
functions.

(For arrow functions, we cannot do that ofc.)

This is needed for later features (PreParser with scope analysis).

-- CL adapted from marja's https://codereview.chromium.org/2411793003/

BUG=

Committed: https://crrev.com/4ff2cafe9309b591b1ecd68823d2a01cedf5efb8
Cr-Commit-Position: refs/heads/master@{#40771}

[Toon Verwaest, 2016-11-04 13:00:16]

verwaest@chromium.org changed reviewers:
+ vogelheim@chromium.org

[Toon Verwaest, 2016-11-04 13:00:17]

ptal

[marja, 2016-11-04 14:25:07]

marja@chromium.org changed reviewers:
+ marja@chromium.org

[marja, 2016-11-04 14:25:08]

generally lg (and not least because it's mostly from my cl ;)

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:3101: 
Any particular reason why you didn't move Expect(LPAREN) here too, like in my
cl?

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/preparser.c...
src/parsing/preparser.cc:143: if ((kind & FunctionKind::kArrowFunction) == 0) {
You already commented on this on my orig cl :)

[marja, 2016-11-04 14:35:09]

lgtm

for lparen, i didn't notice the comment in my orig cl; indeed this version makes
more sense since the scope start position is known when we need the cache key.

[Toon Verwaest, 2016-11-04 14:35:56]

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:3101: 
On 2016/11/04 14:25:07, marja wrote:
> Any particular reason why you didn't move Expect(LPAREN) here too, like in my
> cl?

This avoids adding key to the log, since we know the start-position before
starting the preparse.

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/2472063002/diff/40001/src/parsing/preparser.c...
src/parsing/preparser.cc:143: if ((kind & FunctionKind::kArrowFunction) == 0) {
On 2016/11/04 14:25:07, marja wrote:
> You already commented on this on my orig cl :)

Forgot to upload. Doh! Done

[Toon Verwaest, 2016-11-04 14:37:06]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-11-04 14:37:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 15:04:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:23:07]

Description was changed from

==========
Preparse lazy function parameters

Parameters of a lazily parsed function used to be parsed eagerly, and parameter
handling was split between Parser::ParseFunctionLiteral and
ParseEagerFunctionBody, leading to inconsistencies.

After this CL, we preparse (lazy parse) the parameters of lazily parsed
functions.

(For arrow functions, we cannot do that ofc.)

This is needed for later features (PreParser with scope analysis).

-- CL adapted from marja's https://codereview.chromium.org/2411793003/

BUG=
==========

to

==========
Preparse lazy function parameters

Parameters of a lazily parsed function used to be parsed eagerly, and parameter
handling was split between Parser::ParseFunctionLiteral and
ParseEagerFunctionBody, leading to inconsistencies.

After this CL, we preparse (lazy parse) the parameters of lazily parsed
functions.

(For arrow functions, we cannot do that ofc.)

This is needed for later features (PreParser with scope analysis).

-- CL adapted from marja's https://codereview.chromium.org/2411793003/

BUG=

Committed: https://crrev.com/4ff2cafe9309b591b1ecd68823d2a01cedf5efb8
Cr-Commit-Position: refs/heads/master@{#40771}
==========

[commit-bot: I haz the power, 2016-11-17 22:23:08]

Patchset 4 (id:??) landed as
https://crrev.com/4ff2cafe9309b591b1ecd68823d2a01cedf5efb8
Cr-Commit-Position: refs/heads/master@{#40771}