Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2472053003: Revert of [heap] Add a guard for restarting the memory reducer after mark-compact. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Add a guard for restarting the memory reducer after mark-compact. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2433933005/ ) Reason for revert: Speculative revert to see impact on crbug.com/659531 Original issue's description: > [heap] Add a guard for restarting the memory reducer after mark-compact. > > Currently it is possible to get into a cycle of > mark-compact -> memory reducer -> mark-compact -> memory reducer ... > where the memory reducer does not free memory. > > This patch ensures that the memory reducer restarts only if the > committed memory increased by sufficient amount after the last run. > > BUG= TBR=hpayer@chromium.org,davidroutier17@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/3c96c5e2325461c8d77e3843f9a637cf702563c4 Cr-Commit-Position: refs/heads/master@{#40737}

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -93 lines) Patch
M src/heap/heap.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/memory-reducer.h View 1 4 chunks +3 lines, -12 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 6 chunks +11 lines, -29 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 1 9 chunks +16 lines, -51 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
Created Revert of [heap] Add a guard for restarting the memory reducer after mark-compact.
4 years, 1 month ago (2016-11-03 16:16:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472053003/1
4 years, 1 month ago (2016-11-03 16:16:24 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27780)
4 years, 1 month ago (2016-11-03 16:20:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472053003/120001
4 years, 1 month ago (2016-11-03 17:02:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 1 month ago (2016-11-03 17:26:59 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c96c5e2325461c8d77e3843f9a637cf702563c4
Cr-Commit-Position: refs/heads/master@{#40737}

Powered by Google App Engine
This is Rietveld 408576698