Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2472043003: [Payments] Don't show Organization in billing address selection label. (Closed)
Patch Set: Updated test + Addressed Dan's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 2c739bf29ba0a1e651191c1d1e814955af14c6e7..beb49d2353600f7610128d878105eeffb42dc3c9 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -388,7 +388,10 @@ ScopedJavaLocalRef<jobjectArray>
PersonalDataManagerAndroid::GetProfileLabelsForSettings(
JNIEnv* env,
const JavaParamRef<jobject>& unused_obj) {
- return GetProfileLabels(env, false, false,
+ return GetProfileLabels(env, false /* address_only */,
+ false /* include_name_in_label */,
+ true /* include_organization_in_label */,
+ true /* include_country_in_label */,
personal_data_manager_->GetProfiles());
}
@@ -396,8 +399,12 @@ ScopedJavaLocalRef<jobjectArray>
PersonalDataManagerAndroid::GetProfileLabelsToSuggest(
JNIEnv* env,
const JavaParamRef<jobject>& unused_obj,
- jboolean include_name_in_label) {
- return GetProfileLabels(env, true, include_name_in_label,
+ jboolean include_name_in_label,
+ jboolean include_organization_in_label,
+ jboolean include_country_in_label) {
+ return GetProfileLabels(env, true /* address_only */, include_name_in_label,
+ include_organization_in_label,
+ include_country_in_label,
personal_data_manager_->GetProfilesToSuggest());
}
@@ -770,6 +777,8 @@ ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileLabels(
JNIEnv* env,
bool address_only,
bool include_name_in_label,
+ bool include_organization_in_label,
+ bool include_country_in_label,
std::vector<AutofillProfile*> profiles) {
std::unique_ptr<std::vector<ServerFieldType>> suggested_fields;
size_t minimal_fields_shown = 2;
@@ -777,7 +786,8 @@ ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileLabels(
suggested_fields.reset(new std::vector<ServerFieldType>);
if (include_name_in_label)
suggested_fields->push_back(NAME_FULL);
- suggested_fields->push_back(COMPANY_NAME);
+ if (include_organization_in_label)
+ suggested_fields->push_back(COMPANY_NAME);
suggested_fields->push_back(ADDRESS_HOME_LINE1);
suggested_fields->push_back(ADDRESS_HOME_LINE2);
suggested_fields->push_back(ADDRESS_HOME_DEPENDENT_LOCALITY);
@@ -785,7 +795,8 @@ ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileLabels(
suggested_fields->push_back(ADDRESS_HOME_STATE);
suggested_fields->push_back(ADDRESS_HOME_ZIP);
suggested_fields->push_back(ADDRESS_HOME_SORTING_CODE);
- suggested_fields->push_back(ADDRESS_HOME_COUNTRY);
+ if (include_country_in_label)
+ suggested_fields->push_back(ADDRESS_HOME_COUNTRY);
minimal_fields_shown = suggested_fields->size();
}
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698