Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2472043002: Revert of [heap] Invoke incremental marking step before allocation. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Invoke incremental marking step before allocation. (patchset #1 id:1 of https://codereview.chromium.org/2464393002/ ) Reason for revert: Performance regression on Octane and V8 runtime stats. Original issue's description: > [heap] Invoke incremental marking step before allocation. > > This ensures that the newly allocated object immediatly precedes the > linear allocation area, which is needed for allocation folding. > > For more info see: > https://bugs.chromium.org/p/chromium/issues/detail?id=659165#c13 > > BUG=chromium:659165 TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:659165 Committed: https://crrev.com/8f85aba4eafca816ece83cfed49635e277f0d188 Cr-Commit-Position: refs/heads/master@{#40713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -40 lines) Patch
M src/heap/incremental-marking.h View 4 chunks +18 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +47 lines, -28 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Created Revert of [heap] Invoke incremental marking step before allocation.
4 years, 1 month ago (2016-11-03 09:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472043002/1
4 years, 1 month ago (2016-11-03 09:56:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 09:56:52 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f85aba4eafca816ece83cfed49635e277f0d188
Cr-Commit-Position: refs/heads/master@{#40713}

Powered by Google App Engine
This is Rietveld 408576698