Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2472023004: Add generic argument to Codec.fuse. (Closed)

Created:
4 years, 1 month ago by floitsch
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change from TT to R. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/convert/codec.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years, 1 month ago (2016-11-04 09:06:48 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2472023004/diff/1/sdk/lib/convert/codec.dart File sdk/lib/convert/codec.dart (right): https://codereview.chromium.org/2472023004/diff/1/sdk/lib/convert/codec.dart#newcode65 sdk/lib/convert/codec.dart:65: Codec<S, dynamic/*=TT*/> fuse/*<TT>*/(Codec<T, dynamic/*=TT*/> other) { TT -> ...
4 years, 1 month ago (2016-11-04 09:12:38 UTC) #3
floitsch
https://codereview.chromium.org/2472023004/diff/1/sdk/lib/convert/codec.dart File sdk/lib/convert/codec.dart (right): https://codereview.chromium.org/2472023004/diff/1/sdk/lib/convert/codec.dart#newcode65 sdk/lib/convert/codec.dart:65: Codec<S, dynamic/*=TT*/> fuse/*<TT>*/(Codec<T, dynamic/*=TT*/> other) { On 2016/11/04 09:12:38, ...
4 years, 1 month ago (2016-11-04 09:18:29 UTC) #4
floitsch
4 years, 1 month ago (2016-11-04 09:19:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb968553ae338da26346efaaa949c6a470be0d6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698