Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 2472003004: Avoid matrix inverse in SkBitmapProcInfo::init for translate-only cases (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid matrix inverse in SkBitmapProcInfo::init for translate-only cases If fInvMatrix doesn't have a scale component, the really-close-to-no-scale logic is a no-op. We can avoid an inverse op by hoisting the check out of just_trans_clamp/just_trans_general. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472003004 Committed: https://skia.googlesource.com/skia/+/544da7a7c399ab9775d6dbb441a5a695569f9939

Patch Set 1 #

Patch Set 2 : simplified matrix type test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 2 chunks +22 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
4 years, 1 month ago (2016-11-03 20:30:04 UTC) #2
reed1
lgtm
4 years, 1 month ago (2016-11-03 20:41:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472003004/20001
4 years, 1 month ago (2016-11-03 21:19:22 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:43:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/544da7a7c399ab9775d6dbb441a5a695569f9939

Powered by Google App Engine
This is Rietveld 408576698